From mboxrd@z Thu Jan 1 00:00:00 1970 From: Al Viro Subject: Re: [RFC][PATCH] ensure i_ino uniqueness in filesystems without permanent inode numbers (via idr) Date: Tue, 14 Nov 2006 20:26:25 +0000 Message-ID: <20061114202625.GY29920@ftp.linux.org.uk> References: <1163535728.15846.21.camel@dantu.rdu.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-fsdevel@vger.kernel.org Return-path: Received: from zeniv.linux.org.uk ([195.92.253.2]:64703 "EHLO ZenIV.linux.org.uk") by vger.kernel.org with ESMTP id S966313AbWKNU00 (ORCPT ); Tue, 14 Nov 2006 15:26:26 -0500 To: Jeff Layton Content-Disposition: inline In-Reply-To: <1163535728.15846.21.camel@dantu.rdu.redhat.com> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Tue, Nov 14, 2006 at 03:22:08PM -0500, Jeff Layton wrote: > This patch is a first step at correcting these problems. It declares a > new file_system_type flag (FS_I_INO_DYNAMIC). If this is set, then when > new_inode is called, we'll use the IDR functions to generate a unique > 31-bit value, leaving the first 100 inode numbers for statically > allocated stuff like root inodes, etc. At inode deletion time, we > idr_remove it so the i_ino value can be reused. NAK. All calls of new_inode() are triggered from within fs code; there's no reason to introduce flags (which should be the last resort) when you bloody well can have a separate helpers for that case and have them called. Explicitly.