linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Nick Piggin <npiggin@suse.de>
To: Andreas Schwab <schwab@suse.de>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@osdl.org>,
	linux-fsdevel@vger.kernel.org
Subject: Re: [patch 1/3] mm: pagecache write deadlocks zerolength fix
Date: Thu, 30 Nov 2006 12:30:52 +0100	[thread overview]
Message-ID: <20061130113052.GB12579@wotan.suse.de> (raw)
In-Reply-To: <jeac29teeu.fsf@sykes.suse.de>

On Thu, Nov 30, 2006 at 11:30:33AM +0100, Andreas Schwab wrote:
> Nick Piggin <npiggin@suse.de> writes:
> 
> > On Thu, Nov 30, 2006 at 11:15:39AM +0100, Andreas Schwab wrote:
> >> Nick Piggin <npiggin@suse.de> writes:
> >> 
> >> > writev with a zero-length segment is a noop, and we shouldn't return EFAULT.
> >> 
> >> AFAICS the callers of these functions never pass a zero length.
> >
> > They can in the case of a zero length write.
> 
> How?  All (indirect) callers I could find explicitly handle the
> zero-length case.

Sorry, zero length iov to writev (just had to double-check
there ;).


      reply	other threads:[~2006-11-30 11:30 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-30  7:20 [patch 1/3] mm: pagecache write deadlocks zerolength fix Nick Piggin
2006-11-30  7:22 ` [patch 2/3] mm: pagecache write deadlocks stale holes fix Nick Piggin
2006-11-30  7:22   ` [patch 3/3] fs: fix cont vs deadlock patches Nick Piggin
2006-11-30 11:32     ` Nick Piggin
2006-11-30 22:14       ` OGAWA Hirofumi
2006-12-01  0:27         ` Nick Piggin
2006-12-01  1:11           ` OGAWA Hirofumi
2006-12-01  2:03             ` Nick Piggin
2006-12-01  2:09         ` Nick Piggin
2006-12-01  3:41           ` OGAWA Hirofumi
2006-12-01  3:47             ` Nick Piggin
2006-12-01  5:08             ` Nick Piggin
2006-12-01  7:21               ` Andrew Morton
2006-12-01  7:53                 ` Nick Piggin
2006-12-01 14:50                   ` OGAWA Hirofumi
2006-12-01 15:47                     ` OGAWA Hirofumi
2006-12-02  0:36                     ` Nick Piggin
2006-12-02  7:28                       ` [new patch " Nick Piggin
2006-12-02  9:43                         ` OGAWA Hirofumi
2006-11-30  7:26 ` [patch 0/3] more buffered write fixes Nick Piggin
2006-11-30 10:15 ` [patch 1/3] mm: pagecache write deadlocks zerolength fix Andreas Schwab
2006-11-30 10:19   ` Nick Piggin
2006-11-30 10:30     ` Andreas Schwab
2006-11-30 11:30       ` Nick Piggin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061130113052.GB12579@wotan.suse.de \
    --to=npiggin@suse.de \
    --cc=akpm@osdl.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=schwab@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).