From: Andrew Morton <akpm@osdl.org>
To: Nick Piggin <npiggin@suse.de>
Cc: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-fsdevel@vger.kernel.org
Subject: Re: [patch 3/3] fs: fix cont vs deadlock patches
Date: Thu, 30 Nov 2006 23:21:02 -0800 [thread overview]
Message-ID: <20061130232102.0cc7fc0b.akpm@osdl.org> (raw)
In-Reply-To: <20061201050852.GA31347@wotan.suse.de>
On Fri, 1 Dec 2006 06:08:52 +0100
Nick Piggin <npiggin@suse.de> wrote:
> On Fri, Dec 01, 2006 at 12:41:25PM +0900, OGAWA Hirofumi wrote:
> >
> > Yes, this patch doesn't pass zero-length to prepare_write. However,
> > I'm not checking this patch is ok for reiserfs...
>
> OK, vfat wasn't working correctly for me -- I needed the following patch:
Now I'm confused. What relationship does this patch have to the below?
revert-generic_file_buffered_write-handle-zero-length-iovec-segments.patch
revert-generic_file_buffered_write-deadlock-on-vectored-write.patch
generic_file_buffered_write-cleanup.patch
mm-only-mm-debug-write-deadlocks.patch
mm-fix-pagecache-write-deadlocks.patch
mm-fix-pagecache-write-deadlocks-comment.patch
mm-fix-pagecache-write-deadlocks-xip.patch
mm-fix-pagecache-write-deadlocks-mm-pagecache-write-deadlocks-efault-fix.patch
mm-fix-pagecache-write-deadlocks-zerolength-fix.patch
mm-fix-pagecache-write-deadlocks-stale-holes-fix.patch
fs-prepare_write-fixes.patch
fs-prepare_write-fixes-fuse-fix.patch
fs-prepare_write-fixes-jffs-fix.patch
fs-prepare_write-fixes-fat-fix.patch
fs-fix-cont-vs-deadlock-patches.patch
> Index: linux-2.6/fs/buffer.c
> ===================================================================
> --- linux-2.6.orig/fs/buffer.c 2006-12-01 15:31:22.000000000 +1100
> +++ linux-2.6/fs/buffer.c 2006-12-01 16:02:23.000000000 +1100
> @@ -2102,6 +2102,7 @@
Please always use `diff -p'
> *bytes |= (blocksize-1);
> (*bytes)++;
> }
> +
> status = __block_prepare_write(inode, new_page, zerofrom,
> PAGE_CACHE_SIZE, get_block);
> if (status)
> @@ -2110,7 +2111,7 @@
> memset(kaddr+zerofrom, 0, PAGE_CACHE_SIZE-zerofrom);
> flush_dcache_page(new_page);
> kunmap_atomic(kaddr, KM_USER0);
> - generic_commit_write(NULL, new_page, zerofrom, PAGE_CACHE_SIZE);
> + __block_commit_write(inode, new_page, zerofrom, PAGE_CACHE_SIZE);
Whatever function this is doesn't need to update i_size?
next prev parent reply other threads:[~2006-12-01 7:21 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-30 7:20 [patch 1/3] mm: pagecache write deadlocks zerolength fix Nick Piggin
2006-11-30 7:22 ` [patch 2/3] mm: pagecache write deadlocks stale holes fix Nick Piggin
2006-11-30 7:22 ` [patch 3/3] fs: fix cont vs deadlock patches Nick Piggin
2006-11-30 11:32 ` Nick Piggin
2006-11-30 22:14 ` OGAWA Hirofumi
2006-12-01 0:27 ` Nick Piggin
2006-12-01 1:11 ` OGAWA Hirofumi
2006-12-01 2:03 ` Nick Piggin
2006-12-01 2:09 ` Nick Piggin
2006-12-01 3:41 ` OGAWA Hirofumi
2006-12-01 3:47 ` Nick Piggin
2006-12-01 5:08 ` Nick Piggin
2006-12-01 7:21 ` Andrew Morton [this message]
2006-12-01 7:53 ` Nick Piggin
2006-12-01 14:50 ` OGAWA Hirofumi
2006-12-01 15:47 ` OGAWA Hirofumi
2006-12-02 0:36 ` Nick Piggin
2006-12-02 7:28 ` [new patch " Nick Piggin
2006-12-02 9:43 ` OGAWA Hirofumi
2006-11-30 7:26 ` [patch 0/3] more buffered write fixes Nick Piggin
2006-11-30 10:15 ` [patch 1/3] mm: pagecache write deadlocks zerolength fix Andreas Schwab
2006-11-30 10:19 ` Nick Piggin
2006-11-30 10:30 ` Andreas Schwab
2006-11-30 11:30 ` Nick Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061130232102.0cc7fc0b.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=hirofumi@mail.parknet.co.jp \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=npiggin@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).