From: Nick Piggin <npiggin@suse.de>
To: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>,
linux-fsdevel@vger.kernel.org
Subject: Re: [patch 3/3] fs: fix cont vs deadlock patches
Date: Fri, 1 Dec 2006 03:03:55 +0100 [thread overview]
Message-ID: <20061201020355.GB455@wotan.suse.de> (raw)
In-Reply-To: <873b80v2rx.fsf@duaron.myhome.or.jp>
On Fri, Dec 01, 2006 at 10:11:14AM +0900, OGAWA Hirofumi wrote:
> Nick Piggin <npiggin@suse.de> writes:
>
> > I would be happy if you come up with a quick fix, I'm just trying to
> > stamp out a few big bugs in mm. However I did prefer my way of moving
> > all the exapand code into generic_cont_expand, out of prepare_write, and
> > avoiding holding the target page locked while we're doing all the expand
> > work (strictly, you might be able to get away with this, but it is
> > fragile and ugly).
> >
> > AFAIKS, the only reason to use prepare_write is to avoid passing the
> > get_block into generic_cont_expand?
>
> IIRC, because generic_cont_expand is designed as really generic. It
> can also use for non moronic filesystem.
>
> In the case of reiserfs, it ->prepare_write might be necessary.
Yes I see :(
Well, maybe we should use your alternate patch, then.
I have a few questions on it.
next prev parent reply other threads:[~2006-12-01 2:03 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-30 7:20 [patch 1/3] mm: pagecache write deadlocks zerolength fix Nick Piggin
2006-11-30 7:22 ` [patch 2/3] mm: pagecache write deadlocks stale holes fix Nick Piggin
2006-11-30 7:22 ` [patch 3/3] fs: fix cont vs deadlock patches Nick Piggin
2006-11-30 11:32 ` Nick Piggin
2006-11-30 22:14 ` OGAWA Hirofumi
2006-12-01 0:27 ` Nick Piggin
2006-12-01 1:11 ` OGAWA Hirofumi
2006-12-01 2:03 ` Nick Piggin [this message]
2006-12-01 2:09 ` Nick Piggin
2006-12-01 3:41 ` OGAWA Hirofumi
2006-12-01 3:47 ` Nick Piggin
2006-12-01 5:08 ` Nick Piggin
2006-12-01 7:21 ` Andrew Morton
2006-12-01 7:53 ` Nick Piggin
2006-12-01 14:50 ` OGAWA Hirofumi
2006-12-01 15:47 ` OGAWA Hirofumi
2006-12-02 0:36 ` Nick Piggin
2006-12-02 7:28 ` [new patch " Nick Piggin
2006-12-02 9:43 ` OGAWA Hirofumi
2006-11-30 7:26 ` [patch 0/3] more buffered write fixes Nick Piggin
2006-11-30 10:15 ` [patch 1/3] mm: pagecache write deadlocks zerolength fix Andreas Schwab
2006-11-30 10:19 ` Nick Piggin
2006-11-30 10:30 ` Andreas Schwab
2006-11-30 11:30 ` Nick Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061201020355.GB455@wotan.suse.de \
--to=npiggin@suse.de \
--cc=akpm@osdl.org \
--cc=hirofumi@mail.parknet.co.jp \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).