From mboxrd@z Thu Jan 1 00:00:00 1970 From: Randy Dunlap Subject: Re: [PATCH 21/35] Unionfs: Inode operations Date: Tue, 5 Dec 2006 20:12:41 -0800 Message-ID: <20061205201241.55c1dd9f.randy.dunlap@oracle.com> References: <1165235468365-git-send-email-jsipek@cs.sunysb.edu> <11652354711835-git-send-email-jsipek@cs.sunysb.edu> <20061205135017.3be94142.akpm@osdl.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Jan Engelhardt , "Josef 'Jeff' Sipek" , linux-kernel@vger.kernel.org, torvalds@osdl.org, hch@infradead.org, viro@ftp.linux.org.uk, linux-fsdevel@vger.kernel.org, mhalcrow@us.ibm.com Return-path: To: Andrew Morton In-Reply-To: <20061205135017.3be94142.akpm@osdl.org> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Tue, 5 Dec 2006 13:50:17 -0800 Andrew Morton wrote: > On Tue, 5 Dec 2006 22:27:10 +0100 (MET) > Jan Engelhardt wrote: > > > Someone refresh me: what's the correct[preferred] kdoc style? > > This isn't part of kernel-doc, if that's what you mean. > > > (A) > > /* Lorem ipsum dolor sit amet, consectetur > > * adipisicing elit, sed do eiusmod tempor > > * incididunt ut labore et dolore magna aliqua. */ > > > > (B) > > /* Lorem ipsum dolor sit amet, consectetur > > adipisicing elit, sed do eiusmod tempor > > incididunt ut labore et dolore magna aliqua. */ > > > > (C) > > /* Lorem ipsum dolor sit amet, consectetur > > adipisicing elit, sed do eiusmod tempor incididunt > > ut labore et dolore magna aliqua. */ > > You forgot (D), (E), (F), (G) and a whole lot more besides. > > It doesn't matter a lot what we do, but we should do it one way and not 38 > ways. > > Documentation/CodingStyle doesn't mention commenting at all (eyes roll > heavenwards). I have several (probably 5-6) Doc/CodingStyle changes in my WIP (work-in-progress) folder that I will do in the next few days. > This > > /* > * Lorem ipsum dolor sit amet, consectetur > * adipisicing elit, sed do eiusmod tempor > * incididunt ut labore et dolore magna aliqua. > */ > > is probably the most common, and is what I use when forced to descrog > comments. --- ~Randy