From mboxrd@z Thu Jan 1 00:00:00 1970 From: "J. Bruce Fields" Subject: Re: [PATCH 10/10] gfs2: nfs lock support for gfs2 Date: Thu, 7 Dec 2006 11:21:10 -0500 Message-ID: <20061207162110.GA16858@fieldses.org> References: <20061207152359.GB13613@fieldses.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: linux-fsdevel@vger.kernel.org, David Teigland , nfs@lists.sourceforge.net Return-path: To: Marc Eshel Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: nfs-bounces@lists.sourceforge.net Errors-To: nfs-bounces@lists.sourceforge.net List-Id: linux-fsdevel.vger.kernel.org On Thu, Dec 07, 2006 at 07:43:48AM -0800, Marc Eshel wrote: > nfs-bounces@lists.sourceforge.net wrote on 12/07/2006 07:23:59 AM: > > > On Wed, Dec 06, 2006 at 10:47:46PM -0800, Marc Eshel wrote: > > > if (!rv) { /* got fs lock */ > > > rv = posix_lock_file(file, fl); > > > if (rv) { /* did not get posix lock */ > > > > If we never request the local lock until after we've gotten the lock > > from GFS, then this should never happen. So I think this could just be > > a BUG_ON(rv)--except that would mean a failure in the lock manager could > > oops the kernel, so maybe it'd be better just to printk. > > It can happen if you can not allocate memory. OK, you're right. Hm, the NFS client just seems to print out a warning at this point, though. --b. ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ NFS maillist - NFS@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs