inode i_blksize problem

inode i_blksize problem

[Sergio Paracuellos]

Hi,

First of all sorry for my poor english.

I am trying to compile a module for kernel 2.6.18-1 that uses the 'inode
struct' but the compiler tell me inode struct hasn't a member called
"i_blksize". I don't have that problem in kernel 2.6.16. What happend
with i_blksize?

The funcion is like:

static inline foo (inode_t d, inode_t s)
{
.....

d->i_blksize = s->i_blksize;

...

}

Thanks in advance.

Regards,

	Sergio Paracuellos

Re: inode i_blksize problem

[Matthew Wilcox]

On Wed, Dec 20, 2006 at 01:26:56PM +0100, Sergio Paracuellos wrote:
> I am trying to compile a module for kernel 2.6.18-1 that uses the 'inode
> struct' but the compiler tell me inode struct hasn't a member called
> "i_blksize". I don't have that problem in kernel 2.6.16. What happend
> with i_blksize?

git-log reveals:

commit ba52de123d454b57369f291348266d86f4b35070
Author: Theodore Ts'o <tytso@mit.edu>
Date:   Wed Sep 27 01:50:49 2006 -0700

    [PATCH] inode-diet: Eliminate i_blksize from the inode structure
    
    This eliminates the i_blksize field from struct inode.  Filesystems that wan
t
    to provide a per-inode st_blksize can do so by providing their own getattr
    routine instead of using the generic_fillattr() function.
    
    Note that some filesystems were providing pretty much random (and incorrect)
    values for i_blksize.
    
    [bunk@stusta.de: cleanup]
    [akpm@osdl.org: generic_fillattr() fix]
    Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
    Signed-off-by: Adrian Bunk <bunk@stusta.de>
    Signed-off-by: Andrew Morton <akpm@osdl.org>
    Signed-off-by: Linus Torvalds <torvalds@osdl.org>

So, it's gone.  I'd just delete that line from your sources if I were you.
By the way, what kind of module is this?  Whatever it's doing looks
pretty dodgy to me.