From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Morton <akpm@osdl.org>
Subject: Re: [FSAIO][PATCH 3/8] Routines to initialize and test a wait bit
 key
Date: Thu, 28 Dec 2006 14:42:43 -0800
Message-ID: <20061228144243.a54046dc.akpm@osdl.org>
References: <20061227153855.GA25898@in.ibm.com>
	<20061228082308.GA4476@in.ibm.com>
	<20061228083900.GC6971@in.ibm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: linux-aio@kvack.org, drepper@redhat.com,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	jakub@redhat.com, mingo@elte.hu
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from smtp.osdl.org ([65.172.181.25]:38355 "EHLO smtp.osdl.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S965031AbWL1WnK (ORCPT <rfc822;linux-fsdevel@vger.kernel.org>);
	Thu, 28 Dec 2006 17:43:10 -0500
To: suparna@in.ibm.com
In-Reply-To: <20061228083900.GC6971@in.ibm.com>
Sender: linux-fsdevel-owner@vger.kernel.org
List-Id: linux-fsdevel.vger.kernel.org

On Thu, 28 Dec 2006 14:09:00 +0530
Suparna Bhattacharya <suparna@in.ibm.com> wrote:

> +#define init_wait_bit_key(waitbit, word, bit)				\
> +	do {								\
> +		(waitbit)->key.flags = word;				\
> +		(waitbit)->key.bit_nr = bit;				\
> +	} while (0)
> +
> +#define init_wait_bit_task(waitbit, tsk)				\
> +	do {								\
> +		(waitbit)->wait.private = tsk;				\
> +		(waitbit)->wait.func = wake_bit_function;		\
> +		INIT_LIST_HEAD(&(waitbit)->wait.task_list);		\
> +	} while (0)

Can we convert these to C functions (inlined or regular, probably inlined
would be better)?