From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH -mm 2/10][RFC] aio: net use struct socket for io Date: Mon, 15 Jan 2007 21:44:27 -0800 Message-ID: <20070115214427.7fc55a6c@oldman> References: <20070116015450.9764.37697.patchbomb.py@nate-64.agami.com> <20070116015450.9764.24404.patchbomb.py@nate-64.agami.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Nate Diller , Andrew Morton , Alan Cox , Trond Myklebust , Benjamin LaHaise , Alexander Viro , Suparna Bhattacharya , Kenneth W Chen , David Brownell , Christoph Hellwig , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, netdev@vger.kernel.org, ocfs2-devel@oss.oracle.com, linux-aio@kvack.org, xfs-masters@oss.sgi.com Return-path: Received: from smtp.osdl.org ([65.172.181.24]:47015 "EHLO smtp.osdl.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932373AbXAPFqO (ORCPT ); Tue, 16 Jan 2007 00:46:14 -0500 To: Nate Diller In-Reply-To: <20070116015450.9764.24404.patchbomb.py@nate-64.agami.com> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Mon, 15 Jan 2007 17:54:50 -0800 Nate Diller wrote: > Remove unused arg from socket operations > > The sendmsg and recvmsg socket operations take a kiocb pointer, but none of > the functions actually use it. There's really no need even theoretically, > it's really quite ugly having it there at all. Also, removing it will pave > the way for a more generic completion path in the file_operations. > > --- Would getting rid of these make later implementation of AIO networking harder?