From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jens Axboe Subject: Re: [PATCH: 2.6.20-rc4-mm1] JFS: Avoid deadlock introduced by explicit I/O plugging Date: Thu, 18 Jan 2007 10:46:53 +1100 Message-ID: <20070117234653.GI3508@kernel.dk> References: <1169074549.10560.10.camel@kleikamp.austin.ibm.com> <20070117231847.GH3508@kernel.dk> <1169077157.10560.16.camel@kleikamp.austin.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: JFS Discussion , fsdevel , linux-kernel , Nick Piggin Return-path: Received: from ns.virtualhost.dk ([195.184.98.160]:27024 "EHLO virtualhost.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751100AbXAQXsX (ORCPT ); Wed, 17 Jan 2007 18:48:23 -0500 To: Dave Kleikamp Content-Disposition: inline In-Reply-To: <1169077157.10560.16.camel@kleikamp.austin.ibm.com> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Wed, Jan 17 2007, Dave Kleikamp wrote: > On Thu, 2007-01-18 at 10:18 +1100, Jens Axboe wrote: > > > Can you try io_schedule() and verify that things just work? > > I actually did do that in the first place, but wondered if it was the > right thing to introduce the accounting changes that came with that. > I'll change it back to io_schedule() and test it again, just to make > sure. It appears to be the correct change to me - you really are waiting for IO resources (otherwise it would not hang with the plug change), so doing an inc/dec of iowait around the schedule should be done. > If that's the right fix, I can push it directly since it won't have any > dependencies on your patches. Perfect! -- Jens Axboe