From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 3/3] pipefs and sockfs respin -- make .drop_inode = generic_delete_inode Date: Mon, 22 Jan 2007 20:49:24 +0000 Message-ID: <20070122204924.GA23297@infradead.org> References: <200701221416.l0MEG6le022947@dantu.rdu.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-fsdevel@vger.kernel.org, esandeen@redhat.com, viro@redhat.com Return-path: Received: from pentafluge.infradead.org ([213.146.154.40]:56661 "EHLO pentafluge.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932612AbXAVUt0 (ORCPT ); Mon, 22 Jan 2007 15:49:26 -0500 To: Jeff Layton Content-Disposition: inline In-Reply-To: <200701221416.l0MEG6le022947@dantu.rdu.redhat.com> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Mon, Jan 22, 2007 at 09:16:06AM -0500, Jeff Layton wrote: > A little late since I sent some patches to akpm already, but I'm thinking > that this might be the better way to go. Rather than trying to have the > filesystems manage i_nlink, just make drop_inode for the filesystems be > generic_delete_inode. It seems that some filesystems already do that, and it > seems like that should do the right thing here too. This seems to be a little > easier to follow than messing with i_nlink. > > Does this seem reasonable? If so, I'll send this on to akpm and ask him to > commit this rather than the original pipefs patch I sent. Sounds good to me.