From mboxrd@z Thu Jan 1 00:00:00 1970 From: Randy Dunlap Subject: [PATCH] dlm & gfs2: use sysfs Date: Thu, 25 Jan 2007 18:42:39 -0800 Message-ID: <20070125184239.86d38bd9.rdunlap@xenotime.net> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: swhiteho@redhat.com, akpm To: cluster-devel@redhat.com, linux-fsdevel@vger.kernel.org Return-path: Received: from xenotime.net ([66.160.160.81]:47485 "HELO xenotime.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1030715AbXAZC4T (ORCPT ); Thu, 25 Jan 2007 21:56:19 -0500 Received: from midway.site ([71.245.99.70]) by xenotime.net for ; Thu, 25 Jan 2007 18:46:09 -0800 Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org From: Randy Dunlap With CONFIG_DLM=m, CONFIG_PROC_FS=n, and CONFIG_SYSFS=n, kernel build fails with: WARNING: "kernel_subsys" [fs/gfs2/locking/dlm/lock_dlm.ko] undefined! WARNING: "kernel_subsys" [fs/dlm/dlm.ko] undefined! WARNING: "kernel_subsys" [fs/configfs/configfs.ko] undefined! make[1]: *** [__modpost] Error 1 make: *** [modules] Error 2 Since fs/dlm/lockspace.c and fs/gfs2/locking/dlm/sysfs.c use kernel_subsys, they should either DEPEND on it or SELECT it. Signed-off-by: Randy Dunlap --- fs/dlm/Kconfig | 1 + fs/gfs2/Kconfig | 1 + 2 files changed, 2 insertions(+) --- linux-2620-rc6.orig/fs/dlm/Kconfig +++ linux-2620-rc6/fs/dlm/Kconfig @@ -5,6 +5,7 @@ config DLM tristate "Distributed Lock Manager (DLM)" depends on IPV6 || IPV6=n select CONFIGFS_FS + select SYSFS select IP_SCTP if DLM_SCTP help A general purpose distributed lock manager for kernel or userspace --- linux-2620-rc6.orig/fs/gfs2/Kconfig +++ linux-2620-rc6/fs/gfs2/Kconfig @@ -38,6 +38,7 @@ config GFS2_FS_LOCKING_DLM select IP_SCTP if DLM_SCTP select CONFIGFS_FS select DLM + select SYSFS help Multiple node locking module for GFS2