From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [RFC 0/28] Patches to pass vfsmount to LSM inode security hooks Date: Mon, 5 Feb 2007 18:44:10 +0000 Message-ID: <20070205184410.GA20672@infradead.org> References: <20070205182213.12164.40927.sendpatchset@ermintrude.int.wirex.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, chrisw@sous-sol.org, linux-security-module@vger.kernel.org, agruen@suse.de, viro@zeniv.linux.org.uk To: Tony Jones Return-path: Received: from pentafluge.infradead.org ([213.146.154.40]:34735 "EHLO pentafluge.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932669AbXBESo0 (ORCPT ); Mon, 5 Feb 2007 13:44:26 -0500 Content-Disposition: inline In-Reply-To: <20070205182213.12164.40927.sendpatchset@ermintrude.int.wirex.com> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org Just FYI: Al was very opposed to the idea of passing the vfsmount to the vfs_ helpers, so you should discuss this with him. Looking at the actual patches I see you're lazy in a lot of places. Please make sure that when you introduce a vfsmount argument somewhere that it is _always_ passed and not just when it's conveniant. Yes, that's more work, but then again if you're not consistant anyone half-serious will laught at a security model using this infrasturcture.