From: Nick Piggin <npiggin@suse.de>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
Linux Filesystems <linux-fsdevel@vger.kernel.org>,
Linux Memory Management <linux-mm@kvack.org>
Subject: Re: [patch 9/9] mm: fix pagecache write deadlocks
Date: Tue, 6 Feb 2007 06:53:28 +0100 [thread overview]
Message-ID: <20070206055328.GD16647@wotan.suse.de> (raw)
In-Reply-To: <20070206054905.GC16647@wotan.suse.de>
On Tue, Feb 06, 2007 at 06:49:05AM +0100, Nick Piggin wrote:
> > - If the get_user() doesn't fault, and if we're copying from and to the
> > same page, we know that we've locked it, so nobody will be able to unmap
> > it while we're copying from it.
> >
> > Close, but no cigar! This is still vulnerable to Hugh's ab/ba deadlock
> > scenario.
>
> Yes I considered this too. Hard isn't it?
BTW, there are two different abba deadlocks. It's all documented in the
patch 9/9 description.
next prev parent reply other threads:[~2007-02-06 5:53 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-04 8:49 [patch 0/9] buffered write deadlock fix Nick Piggin
2007-02-04 8:49 ` [patch 1/9] fs: libfs buffered write leak fix Nick Piggin
2007-02-04 8:50 ` [patch 2/9] mm: revert "generic_file_buffered_write(): handle zero length iovec segments" Nick Piggin
2007-02-04 8:50 ` [patch 3/9] mm: revert "generic_file_buffered_write(): deadlock on vectored write" Nick Piggin
2007-02-04 8:50 ` [patch 4/9] mm: generic_file_buffered_write cleanup Nick Piggin
2007-02-04 8:50 ` [patch 5/9] mm: debug write deadlocks Nick Piggin
2007-02-04 8:50 ` [patch 6/9] mm: be sure to trim blocks Nick Piggin
2007-02-04 8:50 ` [patch 7/9] mm: cleanup pagecache insertion operations Nick Piggin
2007-02-04 8:50 ` [patch 8/9] mm: generic_file_buffered_write iovec cleanup Nick Piggin
2007-02-04 8:51 ` [patch 9/9] mm: fix pagecache write deadlocks Nick Piggin
2007-02-04 9:44 ` Andrew Morton
2007-02-04 10:15 ` Nick Piggin
2007-02-04 10:26 ` Christoph Hellwig
2007-02-04 10:30 ` Andrew Morton
2007-02-04 10:46 ` Nick Piggin
2007-02-04 10:50 ` Nick Piggin
2007-02-04 10:56 ` Andrew Morton
2007-02-04 11:03 ` Nick Piggin
2007-02-04 11:15 ` Andrew Morton
2007-02-04 15:10 ` Nick Piggin
2007-02-04 18:36 ` Andrew Morton
2007-02-06 2:25 ` Nick Piggin
2007-02-06 4:41 ` Nick Piggin
2007-02-06 5:30 ` Andrew Morton
2007-02-06 5:49 ` Nick Piggin
2007-02-06 5:53 ` Nick Piggin [this message]
2007-02-04 10:59 ` Anton Altaparmakov
2007-02-04 11:10 ` Andrew Morton
2007-02-04 11:22 ` Nick Piggin
2007-02-04 17:40 ` Anton Altaparmakov
2007-02-06 2:09 ` Nick Piggin
2007-02-06 13:13 ` Anton Altaparmakov
-- strict thread matches above, loose matches on Subject: below --
2007-01-29 10:31 [patch 0/9] buffered write deadlock fix Nick Piggin
2007-01-29 10:33 ` [patch 9/9] mm: fix pagecache write deadlocks Nick Piggin
2007-01-29 11:11 ` Nick Piggin
2007-02-02 23:53 ` Andrew Morton
2007-02-03 1:38 ` Nick Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070206055328.GD16647@wotan.suse.de \
--to=npiggin@suse.de \
--cc=akpm@linux-foundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).