From: Bill Huey (hui) <billh@gnuppy.monkey.org>
To: Christoph Hellwig <hch@lst.de>
Cc: jack@suse.cz, akpm@osdl.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>,
"Bill Huey (hui)" <billh@gnuppy.monkey.org>,
Peter Zijlstra <peter@programming.kicks-ass.net>
Subject: Re: [PATCH] remove sb->s_files and file_list_lock usage in dquot.c
Date: Thu, 8 Feb 2007 01:01:21 -0800 [thread overview]
Message-ID: <20070208090121.GA28005@gnuppy.monkey.org> (raw)
In-Reply-To: <20070206132333.GA9919@lst.de>
On Tue, Feb 06, 2007 at 02:23:33PM +0100, Christoph Hellwig wrote:
> Iterate over sb->s_inodes instead of sb->s_files in add_dquot_ref.
> This reduces list search and lock hold time aswell as getting rid of
> one of the few uses of file_list_lock which Ingo identified as a
> scalability problem.
Christoph,
The i_mutex lock the inode structure is also a source of contention
heavy when running a lot of parallel "find"s. I'm sure that folks
would be open to hearing suggestions regarding how to fix that.
bill
next prev parent reply other threads:[~2007-02-08 9:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-06 13:23 [PATCH] remove sb->s_files and file_list_lock usage in dquot.c Christoph Hellwig
2007-02-06 13:46 ` Jan Kara
2007-02-06 23:50 ` Andrew Morton
2007-02-07 7:22 ` Christoph Hellwig
2007-02-07 18:03 ` Jan Engelhardt
2007-02-07 19:06 ` Christoph Hellwig
2007-02-08 12:22 ` Jan Engelhardt
2007-02-07 8:35 ` Jan Kara
2007-02-08 9:01 ` Bill Huey [this message]
2007-02-09 7:14 ` Bill Huey
2007-02-09 7:23 ` Bill Huey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070208090121.GA28005@gnuppy.monkey.org \
--to=billh@gnuppy.monkey.org \
--cc=akpm@osdl.org \
--cc=hch@lst.de \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peter@programming.kicks-ass.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).