From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bill Huey (hui) <billh@gnuppy.monkey.org>
Subject: Re: [PATCH] remove sb->s_files and file_list_lock usage in dquot.c
Date: Thu, 8 Feb 2007 01:01:21 -0800
Message-ID: <20070208090121.GA28005@gnuppy.monkey.org>
References: <20070206132333.GA9919@lst.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: jack@suse.cz, akpm@osdl.org, linux-fsdevel@vger.kernel.org,
	linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>,
	"Bill Huey (hui)" <billh@gnuppy.monkey.org>,
	Peter Zijlstra <peter@programming.kicks-ass.net>
To: Christoph Hellwig <hch@lst.de>
Return-path: <linux-kernel-owner+glk-linux-kernel-3=40m.gmane.org-S1423109AbXBHJBm@vger.kernel.org>
Content-Disposition: inline
In-Reply-To: <20070206132333.GA9919@lst.de>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: linux-fsdevel.vger.kernel.org

On Tue, Feb 06, 2007 at 02:23:33PM +0100, Christoph Hellwig wrote:
> Iterate over sb->s_inodes instead of sb->s_files in add_dquot_ref.
> This reduces list search and lock hold time aswell as getting rid of
> one of the few uses of file_list_lock which Ingo identified as a
> scalability problem.

Christoph,

The i_mutex lock the inode structure is also a source of contention
heavy when running a lot of parallel "find"s. I'm sure that folks
would be open to hearing suggestions regarding how to fix that.

bill