From mboxrd@z Thu Jan 1 00:00:00 1970 From: "J. Bruce Fields" Subject: Re: File system awareness (or lack thereof) of vfs granting of leases Date: Tue, 20 Feb 2007 11:33:39 -0500 Message-ID: <20070220163339.GA342@fieldses.org> References: <45D6937A.10902@redhat.com> <20070218063948.GC22022@fieldses.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Wendy Cheng , linux-fsdevel@vger.kernel.org To: Robert Rappaport Return-path: Received: from mail.fieldses.org ([66.93.2.214]:56711 "EHLO fieldses.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030238AbXBTQdj (ORCPT ); Tue, 20 Feb 2007 11:33:39 -0500 Content-Disposition: inline In-Reply-To: Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Tue, Feb 20, 2007 at 10:46:51AM -0500, Robert Rappaport wrote: > >We also have the same problem with leases, since we're using leases to > >implement NFSv4 delegations. There's a simple-minded patch here: > > > > http://linux-nfs.org/cgi-bin/gitweb.cgi?p=bfields-2.6.git;a=commitdiff;h=4e8aff5dabe07b2e4e95ef0c741a34f65409087f > > > >I'm not really sure if it's right. > > Thank you both for your helpful replies. In particular, the addition > of the calls to file system specific functions in routines, > fcntl_setlease() and break_lease(), as well as the modifications to > the file_operations and inode_operations structures, pointed to by > Bruce's reply, look exactly like the hooks that I would need to > proceed to resolve my problems. Is there any timetable established > for these modifications to make it into a future release? These hooks > would clearly benefit any cluster file system that has to deal with > leases. We've been concentrating on the posix locks problem first, but that may be done in time for 2.6.22. If someone wants to help--we'll need to figure out how to implement this for gfs2 and/or ocfs2. And any review or testing (e.g. with Samba) would be helpful. --b.