From: Valerie Henson <val_henson@linux.intel.com>
To: Theodore Tso <tytso@mit.edu>
Cc: linux-fsdevel@vger.kernel.org, Can Sar <csar@stanford.edu>,
Junfeng Yang <junfeng@gmail.com>,
Dawson Engler <engler@csl.stanford.edu>
Subject: Re: Fix(es) for ext2 fsync bug
Date: Tue, 20 Feb 2007 21:30:16 +0000 [thread overview]
Message-ID: <20070220213014.GC5264@nifty> (raw)
In-Reply-To: <20070215142020.GA9930@thunk.org>
On Thu, Feb 15, 2007 at 09:20:21AM -0500, Theodore Tso wrote:
>
> It's actually not the case that fsck will complete the truncate for
> file A. The problem is that while e2fsck is processing indirect
> blocks in pass 1, the block which is marked as file A's indirect block
> (but which actually contain's file B's data) gets "fixed" when e2fsck
> sees block numbers which look like illegal block numbers. So this
> ends up corrupting file B's data.
Ah, that's what happens. Thanks for the clarification.
> This is actually legal end result, BTW, since it's POSIX states the
> result of fsync() is undefined if the system crashes. Technically
And POSIX also states that sync() is only required to schedule the
writes, but may return before the actual writing is done. Looks like
the only way you can guarantee data is on-disk according to POSIX is
to reboot the system after every synchronous write. Man, we file
systems developers sure have it easy!
-VAL
next prev parent reply other threads:[~2007-02-20 21:30 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-14 19:54 Fix(es) for ext2 fsync bug Valerie Henson
2007-02-14 20:31 ` David Chinner
2007-02-14 21:26 ` Dave Kleikamp
2007-02-14 23:32 ` David Chinner
2007-02-14 21:08 ` sfaibish
2007-02-15 14:20 ` Theodore Tso
2007-02-15 15:09 ` Dave Kleikamp
2007-02-15 15:59 ` sfaibish
2007-02-15 16:39 ` Dave Kleikamp
2007-02-15 17:15 ` Theodore Tso
2007-02-15 17:52 ` sfaibish
[not found] ` <21e789ec0702151111v4cb2aa8dqa168c886cb909c9@mail.gmail.com>
2007-02-15 19:26 ` Dave Kleikamp
2007-02-15 18:54 ` Dawson Engler
[not found] ` <21e789ec0702151118x1c6af801gd34981d72db0f5b2@mail.gmail.com>
[not found] ` <21e789ec0702151128x744f61e5lb24d2da972af185a@mail.gmail.com>
2007-02-16 1:18 ` Theodore Tso
2007-02-20 21:13 ` Valerie Henson
[not found] ` <21e789ec0702201330x1c2706b7kcd055b97cb37e0e@mail.gmail.com>
2007-02-20 21:39 ` Valerie Henson
2007-02-20 21:47 ` Dawson Engler
2007-02-20 22:25 ` Dave Kleikamp
2007-02-20 21:30 ` Valerie Henson [this message]
2007-02-20 22:12 ` Erez Zadok
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070220213014.GC5264@nifty \
--to=val_henson@linux.intel.com \
--cc=csar@stanford.edu \
--cc=engler@csl.stanford.edu \
--cc=junfeng@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).