From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joel Becker Subject: Re: [patch 2/5] fs: introduce new aops and infrastructure Date: Wed, 14 Mar 2007 23:23:05 -0700 Message-ID: <20070315062305.GA20528@ca-server1.us.oracle.com> References: <20070314112529.13798.35417.sendpatchset@linux.site> <20070314112540.13798.97719.sendpatchset@linux.site> <20070315041329.GB21942@ca-server1.us.oracle.com> <20070315043642.GF15069@wotan.suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Mark Fasheh , Linux Filesystems , Linux Kernel , Christoph Hellwig , Andrew Morton To: Nick Piggin Return-path: Received: from rgminet01.oracle.com ([148.87.113.118]:24946 "EHLO rgminet01.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965489AbXCOGXu (ORCPT ); Thu, 15 Mar 2007 02:23:50 -0400 Content-Disposition: inline In-Reply-To: <20070315043642.GF15069@wotan.suse.de> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Thu, Mar 15, 2007 at 05:36:42AM +0100, Nick Piggin wrote: > On Wed, Mar 14, 2007 at 09:13:29PM -0700, Mark Fasheh wrote: > > Are we going to get rid of the file and intr arguments btw? I'm not sure > > intr is useful, and mapping is probably enough to get whatever we inside > > ->write_begin / ->write_end. > > Yeah, I was going to, but I had this version ready to go so decided > to leave them in at the last minute. We can definitely take them out > if people agree. You're really going to need the file argument around. Some folks care about file->private_data, etc. A good example is nfs_updatepage() from nfs_commit_write(). There's a context on the filp. Mapping can get back to the inode via ->host, but not to the struct file. Joel -- Life's Little Instruction Book #157 "Take time to smell the roses." Joel Becker Principal Software Developer Oracle E-mail: joel.becker@oracle.com Phone: (650) 506-8127