Re: [PATCH 1 of 2] block_page_mkwrite() Implementation V2

David Howells
2007-05-16T13:20:53Z

Nick Piggin <nickpiggin@yahoo.com.au> wrote:

> Dave is using prepare_write here to ensure blocks are allocated in the
> given range. The filesystem's ->nopage function must ensure it is uptodate
> before allowing it to be mapped.

Which is fine... assuming it's called. For blockdev-based filesystems, this
is probably true. But I'm not sure you can guarantee it.

I've seen Ext3, for example, unlocking a page that isn't yet uptodate.
nopage() won't get called on it again, but prepare_write() might. I don't
know why this happens, but it's something I've fallen over in doing
CacheFiles. When reading, readpage() is just called on it again and again
until it is up to date. When writing, prepare_write() is called correctly.

> Consider that the code currently works OK today _without_ page_mkwrite.
> page_mkwrite is being added to do block allocation / reservation.

Which doesn't prove anything. All it means is that PG_uptodate being unset is
handled elsewhere.

David