From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 1 of 2] block_page_mkwrite() Implementation V2 Date: Mon, 19 Mar 2007 12:22:53 +0000 Message-ID: <20070319122252.GA12029@infradead.org> References: <20070318233008.GA32597093@melbourne.sgi.com> <20070319092222.GA1720@infradead.org> <45FE61D3.90105@yahoo.com.au> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Christoph Hellwig , David Chinner , lkml , linux-mm , linux-fsdevel To: Nick Piggin Return-path: Received: from pentafluge.infradead.org ([213.146.154.40]:53379 "EHLO pentafluge.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932436AbXCSMW4 (ORCPT ); Mon, 19 Mar 2007 08:22:56 -0400 Content-Disposition: inline In-Reply-To: <45FE61D3.90105@yahoo.com.au> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Mon, Mar 19, 2007 at 09:11:31PM +1100, Nick Piggin wrote: > I've got the patches in -mm now. I hope they will get merged when the > the next window opens. > > I didn't submit the ->page_mkwrite conversion yet, because I didn't > have any callers to look at. It is is slightly less trivial than for > nopage and nopfn, so having David's block_page_mkwrite is helpful. Yes. I was just wondering whether it makes more sense to do this functionality directly ontop of ->fault instead of converting i over real soon.