* [PATCH] unionfs: sioq not __exit
@ 2007-03-19 22:22 Randy Dunlap
2007-03-19 23:20 ` Josef Sipek
0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2007-03-19 22:22 UTC (permalink / raw)
To: unionfs, linux-fsdevel; +Cc: jsipek, akpm
From: Randy Dunlap <randy.dunlap@oracle.com>
stop_sioq() is called from both __init and __exit functions, so it
shouldn't be marked __exit.
Reported on the kernelnewbies mailing list, but no patch offered there.
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
fs/unionfs/sioq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-2.6.21-rc3-mm2.orig/fs/unionfs/sioq.c
+++ linux-2.6.21-rc3-mm2/fs/unionfs/sioq.c
@@ -40,7 +40,7 @@ int __init init_sioq(void)
return err;
}
-void __exit stop_sioq(void)
+void stop_sioq(void)
{
if (superio_workqueue)
destroy_workqueue(superio_workqueue);
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] unionfs: sioq not __exit
2007-03-19 22:22 [PATCH] unionfs: sioq not __exit Randy Dunlap
@ 2007-03-19 23:20 ` Josef Sipek
0 siblings, 0 replies; 2+ messages in thread
From: Josef Sipek @ 2007-03-19 23:20 UTC (permalink / raw)
To: Randy Dunlap; +Cc: unionfs, linux-fsdevel, akpm
On Mon, Mar 19, 2007 at 03:22:26PM -0700, Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> stop_sioq() is called from both __init and __exit functions, so it
> shouldn't be marked __exit.
>
> Reported on the kernelnewbies mailing list, but no patch offered there.
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Applied.
Thanks.
Josef "Jeff" Sipek.
--
Debugging is twice as hard as writing the code in the first place.
Therefore, if you write the code as cleverly as possible, you are, by
definition, not smart enough to debug it.
- Brian W. Kernighan
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-03-19 23:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-03-19 22:22 [PATCH] unionfs: sioq not __exit Randy Dunlap
2007-03-19 23:20 ` Josef Sipek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).