Re: [ANNOUNCE] new new aops patchset

[Nick Piggin <npiggin@suse.de>]

On Mon, Apr 02, 2007 at 04:56:11PM -0700, Badari Pulavarty wrote:
> On Mon, 2007-04-02 at 14:09 +0200, Nick Piggin wrote:
> > Updated aops patchset against 2.6.21-rc5.
> > 
> > http://www.kernel.org/pub/linux/kernel/people/npiggin/patches/new-aops/
> > 
> > Files/dirs are 2.6.21-rc5-new-aops*
> 
> ext3_write_begin() is computing "start" incorrectly.

Good spotting again, thanks!

> 
> Thanks,
> Badari
> 
> ---
>  fs/ext3/inode.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Index: linux-2.6.21-rc5/fs/ext3/inode.c
> ===================================================================
> --- linux-2.6.21-rc5.orig/fs/ext3/inode.c	2007-04-02 16:06:39.000000000 -0700
> +++ linux-2.6.21-rc5/fs/ext3/inode.c	2007-04-02 16:49:57.000000000 -0700
> @@ -1229,7 +1229,7 @@ static int ext3_write_begin(struct file 
>  	unsigned start, end;
>  
>  	index = pos >> PAGE_CACHE_SHIFT;
> -	start = pos * (PAGE_CACHE_SIZE - 1);
> +	start = pos & (PAGE_CACHE_SIZE - 1);
>  	end = start + len;
>  
>  retry:
>