Re: [ANNOUNCE] new new aops patchset

[Nick Piggin <npiggin@suse.de>]

On Tue, Apr 03, 2007 at 08:59:57AM -0700, Badari Pulavarty wrote:
> On Tue, 2007-04-03 at 01:58 +0200, Nick Piggin wrote:
> > On Mon, Apr 02, 2007 at 01:44:59PM -0700, Badari Pulavarty wrote:
> > > On Mon, 2007-04-02 at 14:09 +0200, Nick Piggin wrote:
> > > > Updated aops patchset against 2.6.21-rc5.
> > > > 
> > > > http://www.kernel.org/pub/linux/kernel/people/npiggin/patches/new-aops/
> > > > 
> > > > Files/dirs are 2.6.21-rc5-new-aops*
> > > > 
> > > > Contains numerous fixes from Mark and myself -- I'd say the core code is
> > > > getting reasonably stable at this point.
> > > 
> > > 
> > > ext3_write_failure() conversion is NOT quite correct.
> > > Old code was returing failure of do_journal_get_write_access(),
> > > where as your changes will return journal_stop(). 
> > 
> > Good catch. This still requires a journal_stop, however?
> 
> Yes.
> > 
> > How's this look?
> 
> Looks good. I am little worried about the page-lock vs journal
> start/stop order.

Yeah that did cross my mind, but the old code does it. You can just
unlock before the journal_stop, it just takes a bit more code.

BTW. this is one thing the new interface is good for (ie. the filesystem
completely controls the page lock).

Of course, this whole thing needs updating for the ext3_write_failure
backout...