From: Mark Fasheh <mark.fasheh@oracle.com>
To: Nick Piggin <npiggin@suse.de>
Cc: Linux Filesystems <linux-fsdevel@vger.kernel.org>, dgc@sgi.com
Subject: Re: 2.6.21-rc5-git12 new aops patchset
Date: Thu, 5 Apr 2007 11:10:11 -0700 [thread overview]
Message-ID: <20070405181011.GJ21982@ca-server1.us.oracle.com> (raw)
In-Reply-To: <20070405094605.GB11102@wotan.suse.de>
On Thu, Apr 05, 2007 at 11:46:05AM +0200, Nick Piggin wrote:
> However, note that as per discussion, we may opt to take perform_write out
> of this patchset, and instead work towards making generic_file_aio_write
> easier to implement. I'm open to discussion, though.
I'd be fine with that - if the file systems can get at all the checks and
iov_iter stuff it lets them fine tune their write logic. Ocfs2 for instance
has very different locking for o_direct / buffered and so goes to some bit
of pain to avoid the fallback code in __generic_file_aio_write_nolock().
It'd be much simpler to just call some helpers for buffered writes and
change the code to never do that.
--Mark
--
Mark Fasheh
Senior Software Developer, Oracle
mark.fasheh@oracle.com
prev parent reply other threads:[~2007-04-05 18:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-05 9:46 2.6.21-rc5-git12 new aops patchset Nick Piggin
2007-04-05 16:22 ` Badari Pulavarty
2007-04-06 1:39 ` Nick Piggin
2007-04-05 18:10 ` Mark Fasheh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070405181011.GJ21982@ca-server1.us.oracle.com \
--to=mark.fasheh@oracle.com \
--cc=dgc@sgi.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=npiggin@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).