From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Fasheh Subject: Re: 2.6.21-rc5-git12 new aops patchset Date: Thu, 5 Apr 2007 11:10:11 -0700 Message-ID: <20070405181011.GJ21982@ca-server1.us.oracle.com> References: <20070405094605.GB11102@wotan.suse.de> Reply-To: Mark Fasheh Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Linux Filesystems , dgc@sgi.com To: Nick Piggin Return-path: Received: from rgminet01.oracle.com ([148.87.113.118]:51762 "EHLO rgminet01.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1767185AbXDESKT (ORCPT ); Thu, 5 Apr 2007 14:10:19 -0400 Content-Disposition: inline In-Reply-To: <20070405094605.GB11102@wotan.suse.de> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Thu, Apr 05, 2007 at 11:46:05AM +0200, Nick Piggin wrote: > However, note that as per discussion, we may opt to take perform_write out > of this patchset, and instead work towards making generic_file_aio_write > easier to implement. I'm open to discussion, though. I'd be fine with that - if the file systems can get at all the checks and iov_iter stuff it lets them fine tune their write logic. Ocfs2 for instance has very different locking for o_direct / buffered and so goes to some bit of pain to avoid the fallback code in __generic_file_aio_write_nolock(). It'd be much simpler to just call some helpers for buffered writes and change the code to never do that. --Mark -- Mark Fasheh Senior Software Developer, Oracle mark.fasheh@oracle.com