Re: 2.6.21-rc5-git12 new aops patchset

[Nick Piggin <npiggin@suse.de>]

On Thu, Apr 05, 2007 at 09:22:35AM -0700, Badari Pulavarty wrote:
> On Thu, 2007-04-05 at 11:46 +0200, Nick Piggin wrote:
> > http://www.kernel.org/pub/linux/kernel/people/npiggin/patches/new-aops/
> > 
> > Files are 2.6.21-rc5-git12*
> 
> 
> ext3_ordered_write_end() did
> 
> +		ret = block_write_end(file, mapping, pos, len, copied, page, fsdata);
> +		if (ret >= 0)
> +			copied = ret;
> 	}
>  	ret2 = ext3_journal_stop(handle);
>  	if (!ret)
>  		ret = ret2;
> -	return ret;
> +	return ret ? ret : copied;
> 
> If we do this, we are going to ignore ext3_journal_stop() errors
> almost all the time (since "ret" will be mostly positive).
> 
> Instead can we do this ?
> 
> +		copied = block_write_end(file, mapping, pos, len, copied, page, fsdata);
> +		if (copied < 0)
> +			ret = copied;

Definitely, thank you.

Nick