From: "J. Bruce Fields" <bfields@fieldses.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: akpm@osdl.org, Trond Myklebust <Trond.Myklebust@netapp.com>,
Marc Eshel <eshel@almaden.ibm.com>,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 3/17] locks: make ->lock release private data before returning in GETLK case
Date: Sun, 8 Apr 2007 14:32:45 -0400 [thread overview]
Message-ID: <20070408183245.GA10331@fieldses.org> (raw)
In-Reply-To: <20070406174618.GC32549@infradead.org>
On Fri, Apr 06, 2007 at 06:46:18PM +0100, Christoph Hellwig wrote:
> On Thu, Apr 05, 2007 at 07:40:53PM -0400, J. Bruce Fields wrote:
> > diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c
> > index f52cf5c..d557a51 100644
> > --- a/fs/nfs/nfs4proc.c
> > +++ b/fs/nfs/nfs4proc.c
> > @@ -3019,6 +3019,8 @@ static int _nfs4_proc_getlk(struct nfs4_state *state, int cmd, struct file_lock
> > status = 0;
> > }
> > out:
> > + if (request->fl_ops)
> > + request->fl_ops->fl_release_private(request);
>
> Don't we know which fl_release_private instace we'll call and could
> do a direct call instead?
Yeah. It's currently private to another file, but that could obviously
be fixed. The fl_ops check is still required, though. I could go
either way.
--b.
next prev parent reply other threads:[~2007-04-08 18:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-06 17:46 [PATCH 3/17] locks: make ->lock release private data before returning in GETLK case Christoph Hellwig
2007-04-08 18:32 ` J. Bruce Fields [this message]
[not found] <117581646786-git-send-email->
[not found] ` <11758164673642-git-send-email->
[not found] ` <11758164671398-git-send-email->
2007-04-05 23:40 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070408183245.GA10331@fieldses.org \
--to=bfields@fieldses.org \
--cc=Trond.Myklebust@netapp.com \
--cc=akpm@osdl.org \
--cc=eshel@almaden.ibm.com \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox