From: "J. Bruce Fields" <bfields@fieldses.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: akpm@osdl.org, Trond Myklebust <Trond.Myklebust@netapp.com>,
Marc Eshel <eshel@almaden.ibm.com>,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 8/17] locks: add fl_notify arguments for asynchronous lock return
Date: Tue, 10 Apr 2007 17:49:10 -0400 [thread overview]
Message-ID: <20070410214910.GK7502@fieldses.org> (raw)
In-Reply-To: <20070409184041.GA28716@infradead.org>
On Mon, Apr 09, 2007 at 07:40:41PM +0100, Christoph Hellwig wrote:
> On Thu, Apr 05, 2007 at 07:40:58PM -0400, J. Bruce Fields wrote:
> > We're using fl_notify to asynchronously return the result of a lock
> > request. So we want fl_notify to be able to return a status and, if
> > appropriate, a conflicting lock.
> >
> > This only current caller of fl_notify is in the blocked case, in which case
> > we don't use these extra arguments.
> >
> > We also allow fl_notify to return an error. (Also ignored for now.)
>
> I don't really like the overload of fl_notify. What the reason not
> to use a separate callback?
My vague memory is that Trond said something to the affect of "fl_notify
is there, let's use it rather than adding yet another callback."
But our new usage of fl_notify does requires slightly different
arguments and returns, and is used in a subtly different case. So I
wouldn't object to a new callback. Trond?
--b.
next prev parent reply other threads:[~2007-04-10 21:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-09 18:40 [PATCH 8/17] locks: add fl_notify arguments for asynchronous lock return Christoph Hellwig
2007-04-10 21:49 ` J. Bruce Fields [this message]
[not found] <117581646786-git-send-email->
[not found] ` <11758164673642-git-send-email->
[not found] ` <11758164671398-git-send-email->
[not found] ` <11758164672114-git-send-email->
[not found] ` <11758164672880-git-send-email->
[not found] ` <1175816467294-git-send-email->
[not found] ` <11758164671240-git-send-email->
[not found] ` <11758164686-git-send-email->
2007-04-05 23:40 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070410214910.GK7502@fieldses.org \
--to=bfields@fieldses.org \
--cc=Trond.Myklebust@netapp.com \
--cc=akpm@osdl.org \
--cc=eshel@almaden.ibm.com \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox