From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?utf-8?B?SsO2cm4=?= Engel Subject: Re: [PATCH 1/13] fs: convert core functions to zero_user_page Date: Wed, 11 Apr 2007 16:54:22 +0200 Message-ID: <20070411145420.GB3531@lazybastard.org> References: <20070411033600.11000.38285.patchbomb.py@localhost> <20070410225638.476cf89b.akpm@linux-foundation.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Nate Diller , Alexander Viro , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org To: Andrew Morton Return-path: Received: from lazybastard.de ([212.112.238.170]:54455 "EHLO longford.lazybastard.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752863AbXDKO6U (ORCPT ); Wed, 11 Apr 2007 10:58:20 -0400 Content-Disposition: inline In-Reply-To: <20070410225638.476cf89b.akpm@linux-foundation.org> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Tue, 10 April 2007 22:56:38 -0700, Andrew Morton wrote: >=20 > And I'm surprised that this: >=20 > +static inline void memclear_highpage_flush(struct page *page, unsign= ed int offset, unsigned int size) > +{ > + return zero_user_page(page, offset, size); > +} >=20 > compiled. zero_user_page() returns void... As does memclear_highpage_flush(). Some of my code looks like: void some_func(...) { if (foo) return do_foo(...); if (bar) return do_bar(...); ... } do_foo() and do_bar() also return void. Saves an extra line for the return statment and the brackets. Doesn't help in the code you quoted, of course. J=C3=B6rn --=20 Measure. Don't tune for speed until you've measured, and even then don't unless one part of the code overwhelms the rest. -- Rob Pike - To unsubscribe from this list: send the line "unsubscribe linux-fsdevel= " in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html