From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nate Diller <nate.diller@gmail.com>
Subject: [PATCH 5/17] hfsplus: remove redundant read_mapping_page error check
Date: Wed, 11 Apr 2007 19:49:38 -0700
Message-ID: <20070412024938.27380.6659.patchbomb.py@localhost>
References: <20070412024938.27380.54538.patchbomb.py@localhost>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	reiserfs-dev@namesys.com
To: Andrew Morton <akpm@osdl.org>,
	Alexander Viro <viro@zeniv.linux.org.uk>,
	Christoph Hellwig <hch@infradead.org>,
	Roman Zippel <zippel@linux-m68k.org>,
	Mikulas Patocka <mikulas@artax.karlin.mff.cuni.cz>,
	David Woodhouse <dwmw2@infradead.org>,
	Dave Kleikamp <shaggy@austin.ibm.com>,
	Anton Altaparmakov <aia21@cantab.net>,
	Evgeniy Dushistov <dushistov@mail.ru>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from qb-out-0506.google.com ([72.14.204.239]:54681 "EHLO
	qb-out-0506.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1161515AbXDLCwA (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Wed, 11 Apr 2007 22:52:00 -0400
Received: by qb-out-0506.google.com with SMTP id q10so34037qbq
        for <linux-fsdevel@vger.kernel.org>; Wed, 11 Apr 2007 19:52:00 -0700 (PDT)
In-Reply-To: <20070412024938.27380.54538.patchbomb.py@localhost>
Sender: linux-fsdevel-owner@vger.kernel.org
List-Id: linux-fsdevel.vger.kernel.org

Now that read_mapping_page() does error checking internally, there is no
need to check PageError here.

Signed-off-by: Nate Diller <nate.diller@gmail.com> 

--- 

diff -urpN -X dontdiff linux-2.6.21-rc6-mm1/fs/hfsplus/bnode.c linux-2.6.21-rc6-mm1-test/fs/hfsplus/bnode.c
--- linux-2.6.21-rc6-mm1/fs/hfsplus/bnode.c	2007-04-09 17:20:13.000000000 -0700
+++ linux-2.6.21-rc6-mm1-test/fs/hfsplus/bnode.c	2007-04-10 21:28:45.000000000 -0700
@@ -442,10 +442,6 @@ static struct hfs_bnode *__hfs_bnode_cre
 		page = read_mapping_page(mapping, block, NULL);
 		if (IS_ERR(page))
 			goto fail;
-		if (PageError(page)) {
-			page_cache_release(page);
-			goto fail;
-		}
 		page_cache_release(page);
 		node->page[i] = page;
 	}