From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [AppArmor 01/41] Pass struct vfsmount to the inode_create LSM hook Date: Thu, 12 Apr 2007 11:06:28 +0100 Message-ID: <20070412100628.GA25078@infradead.org> References: <20070412090809.917795000@suse.de> <20070412090836.207973000@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, linux-fsdevel@vger.kernel.org, chrisw@sous-sol.org, Tony Jones , Andreas Gruenbacher To: jjohansen@suse.de Return-path: Content-Disposition: inline In-Reply-To: <20070412090836.207973000@suse.de> Sender: linux-security-module-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Thu, Apr 12, 2007 at 02:08:10AM -0700, jjohansen@suse.de wrote: > This is needed for computing pathnames in the AppArmor LSM. > > Signed-off-by: Tony Jones > Signed-off-by: Andreas Gruenbacher > Signed-off-by: John Johansen > > --- > fs/namei.c | 2 +- > include/linux/security.h | 9 ++++++--- > security/dummy.c | 2 +- > security/selinux/hooks.c | 3 ++- > 4 files changed, 10 insertions(+), 6 deletions(-) > > --- a/fs/namei.c > +++ b/fs/namei.c > @@ -1503,7 +1503,7 @@ int vfs_create(struct inode *dir, struct > return -EACCES; /* shouldn't it be ENOSYS? */ > mode &= S_IALLUGO; > mode |= S_IFREG; > - error = security_inode_create(dir, dentry, mode); > + error = security_inode_create(dir, dentry, nd ? nd->mnt : NULL, mode); Once again very strong NACK. Every conditional passing of vfsmounts get my veto. As mentioned last time if you really want this send a patch series first that passed the vfsmount consistantly.