Re: [Devel] Re: [patch 05/10] add "permit user mounts in new namespace" clone flag

Eric W. Biederman
2007-04-17T18:20:45Z

Miklos Szeredi <miklos@szeredi.hu> writes:

> I'm still not sure, what your problem is.

My problem right now is that I see a serious complexity escalation in
the user interface that we must support indefinitely.

I see us taking a nice powerful concept and seriously watering it down.
To some extent we have to avoid confusing suid applications. (I would
so love to remove the SUID bit...).

I'm being contrary to ensure we have a good code review.

I have heard it said that there are two kinds of design. Something
so simple it obviously has no deficiencies. Something so complex it has
no obvious deficiencies. I am very much afraid we are slipping the
mount namespace into the latter category of work. Which is a bad
bad thing for core OS feature.

> With the v3 of the usermounts patchset, by default, user mounts are
> disabled, because the "allow unpriv submounts" flag is cleared on all
> mounts.
>
> There are several options available to sysadmins and distro builders
> to enable user mounts in a secure way:
>
> - pam module, which creates a private namespace, and sets "allow
> unpriv submounts" on the mounts within the namespace
>
> - pam module, which rbinds / onto /mnt/ns/$USER, and chroots into
> /mnt/ns/$USER, then sets the "allow unpriv submounts" on the
> mounts under /mnt/ns/$USER.

In part this really disturbs me because we now have two mechanisms for
controlling the scope of what a user can do.

A flag or a new namespace. Two mechanisms to accomplish the same
thing sound wrong, and hard to manage.

> - sysadmin creates /mnt/usermounts writable to all users, with
> sticky bit (same as /tmp), does "mount --bind /mnt/usermounts
> /mnt/usermounts" and sets the "allow unpriv submounts" on
> /mnt/usermounts.
>
> All of these are perfectly safe wrt userdel and backup (assuming it
> doesn't try back up /mnt).

I also don't understand at all the user= mount flag and options.
All it seemed to be used for was adding permissions to unmount. In user
space to deal with the lack of any form of untrusted mounts I can understand
this. In kernel space this seems to be more of a problem.

Eric