From mboxrd@z Thu Jan 1 00:00:00 1970 From: Randy Dunlap Subject: Re: [nameidata 2/2] Pass no useless nameidata to the create, lookup, and permission IOPs Date: Mon, 16 Apr 2007 09:42:25 -0700 Message-ID: <20070416094225.2616c4b6.randy.dunlap@oracle.com> References: <20070412090809.917795000@suse.de> <20070412090836.207973000@suse.de> <20070412100628.GA25078@infradead.org> <200704161829.20669.agruen@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Christoph Hellwig , jjohansen@suse.de, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, linux-fsdevel@vger.kernel.org, chrisw@sous-sol.org, Tony Jones To: Andreas Gruenbacher Return-path: In-Reply-To: <200704161829.20669.agruen@suse.de> Sender: linux-security-module-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Mon, 16 Apr 2007 18:29:20 +0200 Andreas Gruenbacher wrote: > Here is a patch with request for comment. > > --- a/include/linux/namei.h > +++ b/include/linux/namei.h > @@ -14,21 +14,39 @@ struct open_intent { > > enum { MAX_NESTED_LINKS = 8 }; > > +/** Please don't use the kernel-doc begin-marker "/**" when the comment block isn't in kernel-doc format. > + * Fields shared between nameidata and nameidata2 -- nameidata2 could > + * be embedded in nameidata, but then the vfs code would become > + * cluttered with dereferences. > + */ > +#define __NAMEIDATA2 \ > + struct dentry *dentry; \ > + struct vfsmount *mnt; \ > + unsigned int flags; \ > + \ > + union { \ > + struct open_intent open; \ > + } intent; > + --- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code ***