From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: 2.6.21-rc6 new aops patchset Date: Tue, 17 Apr 2007 10:33:23 +0100 Message-ID: <20070417093323.GA4328@infradead.org> References: <20070412044852.GA31961@wotan.suse.de> <20070417001932.GT21982@ca-server1.us.oracle.com> <20070417055944.GA1057@wotan.suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Mark Fasheh , Linux Filesystems To: Nick Piggin Return-path: Received: from pentafluge.infradead.org ([213.146.154.40]:46456 "EHLO pentafluge.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753108AbXDQJds (ORCPT ); Tue, 17 Apr 2007 05:33:48 -0400 Content-Disposition: inline In-Reply-To: <20070417055944.GA1057@wotan.suse.de> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Tue, Apr 17, 2007 at 07:59:44AM +0200, Nick Piggin wrote: > I'll possibly omit the perform_write stuff in the first -mm merge, so > that we can get the basics reviewed and working, and exercise the > write_begin/write_end paths well first. I agree. One thing that should be done for the merge is getting rid of ->prepare_write and ->commit_write. Historic data show that if we start a partial transition it will take ages to finish it. In addition to that the backwards compatibility code in this case is rather big and very ugly, and we'd be better off without it.