From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nick Piggin Subject: Re: [patch 16/44] rd convert to new aops Date: Tue, 24 Apr 2007 13:05:49 +0200 Message-ID: <20070424110549.GC32738@wotan.suse.de> References: <20070424012346.696840000@suse.de> <20070424013434.737154000@suse.de> <20070424104647.GB13268@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Andrew Morton , Linux Filesystems , Mark Fasheh To: Christoph Hellwig Return-path: Received: from mail.suse.de ([195.135.220.2]:55424 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752906AbXDXLFv (ORCPT ); Tue, 24 Apr 2007 07:05:51 -0400 Content-Disposition: inline In-Reply-To: <20070424104647.GB13268@infradead.org> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Tue, Apr 24, 2007 at 11:46:47AM +0100, Christoph Hellwig wrote: > > + page = __grab_cache_page(mapping, index); > > btw, __grab_cache_page should probably get a more descriptive and > non-__-prefixed name now that it's used all over the place. Agreed. Suggestions? ;)