From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christoph Hellwig <hch@infradead.org>
Subject: Re: [patch 16/44] rd convert to new aops
Date: Tue, 24 Apr 2007 12:11:19 +0100
Message-ID: <20070424111119.GA17085@infradead.org>
References: <20070424012346.696840000@suse.de> <20070424013434.737154000@suse.de> <20070424104647.GB13268@infradead.org> <20070424110549.GC32738@wotan.suse.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Christoph Hellwig <hch@infradead.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Linux Filesystems <linux-fsdevel@vger.kernel.org>,
	Mark Fasheh <mark.fasheh@oracle.com>
To: Nick Piggin <npiggin@suse.de>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from pentafluge.infradead.org ([213.146.154.40]:60350 "EHLO
	pentafluge.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S932564AbXDXLLV (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Tue, 24 Apr 2007 07:11:21 -0400
Content-Disposition: inline
In-Reply-To: <20070424110549.GC32738@wotan.suse.de>
Sender: linux-fsdevel-owner@vger.kernel.org
List-Id: linux-fsdevel.vger.kernel.org

On Tue, Apr 24, 2007 at 01:05:49PM +0200, Nick Piggin wrote:
> On Tue, Apr 24, 2007 at 11:46:47AM +0100, Christoph Hellwig wrote:
> > > +	page = __grab_cache_page(mapping, index);
> > 
> > btw, __grab_cache_page should probably get a more descriptive and
> > non-__-prefixed name now that it's used all over the place.
> 
> Agreed. Suggestions? ;)

find_or_create_cache_page given that's it's like find_or_create_page +
add_to_page_cache?