From: David Miller <davem@davemloft.net>
To: dhowells@redhat.com
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org, netdev@vger.kernel.org,
kaber@trash.net
Subject: Re: [PATCH 5/5] AFS: Adjust the new netdevice scanning code
Date: Thu, 03 May 2007 03:29:49 -0700 (PDT) [thread overview]
Message-ID: <20070503.032949.65795400.davem@davemloft.net> (raw)
In-Reply-To: <20070503095336.26912.55434.stgit@warthog.cambridge.redhat.com>
From: David Howells <dhowells@redhat.com>
Date: Thu, 03 May 2007 10:53:36 +0100
> Adjust the new netdevice scanning code provided by Patrick McHardy:
>
> (1) Restore the function banner comments that were dropped.
>
> (2) Rather than using an array size of 6 in some places and an array size of
> ETH_ALEN in others, pass a pointer instead and pass the array size
> through so that we can actually check it.
>
> (3) Do the buffer fill count check before checking the for_primary_ifa
> condition again. This permits us to skip that check should maxbufs be
> reached before we run out of interfaces.
>
> Signed-off-by: David Howells <dhowells@redhat.com>
Applied, thanks.
next prev parent reply other threads:[~2007-05-03 10:29 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-03 9:53 [PATCH 1/5] [NETLINK]: Fix use after free in netlink_recvmsg David Howells
2007-05-03 9:53 ` [PATCH 2/5] [AFS]: Fix memory leak in SRXAFSCB_GetCapabilities David Howells
2007-05-03 10:27 ` David Miller
2007-05-03 9:53 ` [PATCH 3/5] [NET]: Add __dev_getfirstbyhwtype David Howells
2007-05-03 10:28 ` David Miller
2007-05-03 9:53 ` [PATCH 4/5] [AFS]: Replace rtnetlink client by direct dev_base walking David Howells
2007-05-03 10:28 ` David Miller
2007-05-03 9:53 ` [PATCH 5/5] AFS: Adjust the new netdevice scanning code David Howells
2007-05-03 10:29 ` David Miller [this message]
2007-05-03 10:27 ` [PATCH 1/5] [NETLINK]: Fix use after free in netlink_recvmsg David Miller
2007-05-03 12:27 ` Marcel Holtmann
2007-05-03 12:46 ` Patrick McHardy
2007-05-03 20:11 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070503.032949.65795400.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@osdl.org \
--cc=dhowells@redhat.com \
--cc=kaber@trash.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).