From: David Howells <dhowells@redhat.com>
To: akpm@osdl.org
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
netdev@vger.kernel.org, kaber@trash.net, dhowells@redhat.com
Subject: [PATCH 3/5] [NET]: Add __dev_getfirstbyhwtype
Date: Thu, 03 May 2007 10:53:26 +0100 [thread overview]
Message-ID: <20070503095325.26912.37429.stgit@warthog.cambridge.redhat.com> (raw)
In-Reply-To: <20070503095315.26912.24270.stgit@warthog.cambridge.redhat.com>
Add __dev_getfirstbyhwtype for callers that don't want a reference but
some data from the device and thus need to take the rtnl anyway.
Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: David Howells <dhowells@redhat.com>
---
include/linux/netdevice.h | 1 +
net/core/dev.c | 21 ++++++++++++++++-----
2 files changed, 17 insertions(+), 5 deletions(-)
diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
index ac0c92b..4428f1c 100644
--- a/include/linux/netdevice.h
+++ b/include/linux/netdevice.h
@@ -582,6 +582,7 @@ extern int netdev_boot_setup_check(struct net_device *dev);
extern unsigned long netdev_boot_base(const char *prefix, int unit);
extern struct net_device *dev_getbyhwaddr(unsigned short type, char *hwaddr);
extern struct net_device *dev_getfirstbyhwtype(unsigned short type);
+extern struct net_device *__dev_getfirstbyhwtype(unsigned short type);
extern void dev_add_pack(struct packet_type *pt);
extern void dev_remove_pack(struct packet_type *pt);
extern void __dev_remove_pack(struct packet_type *pt);
diff --git a/net/core/dev.c b/net/core/dev.c
index eb99900..c305819 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -576,17 +576,28 @@ struct net_device *dev_getbyhwaddr(unsigned short type, char *ha)
EXPORT_SYMBOL(dev_getbyhwaddr);
-struct net_device *dev_getfirstbyhwtype(unsigned short type)
+struct net_device *__dev_getfirstbyhwtype(unsigned short type)
{
struct net_device *dev;
- rtnl_lock();
+ ASSERT_RTNL();
for (dev = dev_base; dev; dev = dev->next) {
- if (dev->type == type) {
- dev_hold(dev);
+ if (dev->type == type)
break;
- }
}
+ return dev;
+}
+
+EXPORT_SYMBOL(__dev_getfirstbyhwtype);
+
+struct net_device *dev_getfirstbyhwtype(unsigned short type)
+{
+ struct net_device *dev;
+
+ rtnl_lock();
+ dev = __dev_getfirstbyhwtype(type);
+ if (dev)
+ dev_hold(dev);
rtnl_unlock();
return dev;
}
next prev parent reply other threads:[~2007-05-03 9:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-03 9:53 [PATCH 1/5] [NETLINK]: Fix use after free in netlink_recvmsg David Howells
2007-05-03 9:53 ` [PATCH 2/5] [AFS]: Fix memory leak in SRXAFSCB_GetCapabilities David Howells
2007-05-03 10:27 ` David Miller
2007-05-03 9:53 ` David Howells [this message]
2007-05-03 10:28 ` [PATCH 3/5] [NET]: Add __dev_getfirstbyhwtype David Miller
2007-05-03 9:53 ` [PATCH 4/5] [AFS]: Replace rtnetlink client by direct dev_base walking David Howells
2007-05-03 10:28 ` David Miller
2007-05-03 9:53 ` [PATCH 5/5] AFS: Adjust the new netdevice scanning code David Howells
2007-05-03 10:29 ` David Miller
2007-05-03 10:27 ` [PATCH 1/5] [NETLINK]: Fix use after free in netlink_recvmsg David Miller
2007-05-03 12:27 ` Marcel Holtmann
2007-05-03 12:46 ` Patrick McHardy
2007-05-03 20:11 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070503095325.26912.37429.stgit@warthog.cambridge.redhat.com \
--to=dhowells@redhat.com \
--cc=akpm@osdl.org \
--cc=kaber@trash.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).