From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kara Subject: Re: [PATCH] Implement renaming for debugfs Date: Thu, 3 May 2007 11:54:52 +0200 Message-ID: <20070503095452.GC12229@duck.suse.cz> References: <20070430175536.GK28367@duck.suse.cz> <20070502032627.GA7845@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-fsdevel@vger.kernel.org To: Greg KH Return-path: Received: from styx.suse.cz ([82.119.242.94]:42732 "EHLO duck.suse.cz" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1030973AbXECJpP (ORCPT ); Thu, 3 May 2007 05:45:15 -0400 Content-Disposition: inline In-Reply-To: <20070502032627.GA7845@kroah.com> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Tue 01-05-07 20:26:27, Greg KH wrote: > On Mon, Apr 30, 2007 at 07:55:36PM +0200, Jan Kara wrote: > > Hello, > > > > attached patch implements renaming for debugfs. I was asked for this > > feature by WLAN guys and I guess it makes sence (they have some debug info > > in the directory identified by interface name and that can change...). > > Could someone have a look at what I wrote whether it looks reasonable? > > Thanks. > > > > Honza > > > > -- > > Jan Kara > > SuSE CR Labs > > > Implement debugfs_rename() to allow renaming files/directories in debugfs. > > I think you are going to need more infrastructure here, the caller > doesn't want to have to allocate a new dentry themselves, they just want > to pass in the new filename :) Actually, I wanted the call to be in the spirit of other debugfs calls. So we have for example: void debugfs_remove(struct dentry *dentry) struct dentry *debugfs_create_dir(const char *name, struct dentry *parent) etc. So it seemed to me that the interface with dentries was perfectly appropriate... One possibility would be to take filename of a file to rename instead of old_dentry. But dirs should IMHO remain to be dentries... Honza -- Jan Kara SuSE CR Labs