From: David Miller <davem@davemloft.net>
To: dhowells@redhat.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] AF_RXRPC: Sort out MTU handling
Date: Fri, 04 May 2007 12:42:25 -0700 (PDT) [thread overview]
Message-ID: <20070504.124225.111205875.davem@davemloft.net> (raw)
In-Reply-To: <20070504145647.19125.99441.stgit@warthog.cambridge.redhat.com>
From: David Howells <dhowells@redhat.com>
Date: Fri, 04 May 2007 15:56:47 +0100
> Sort out the MTU determination and handling in AF_RXRPC:
>
> (1) If it's present, parse the additional information supplied by the peer at
> the end of the ACK packet (struct ackinfo) to determine the MTU sizes
> that peer is willing to support.
>
> (2) Initialise the MTU size to that peer from the kernel's routing records.
>
> (3) Send ACKs rather than ACKALLs as the former carry the additional info,
> and the latter do not.
>
> (4) Declare the interface MTU size in outgoing ACKs as a maximum amount of
> data that can be stuffed into an RxRPC packet without it having to be
> fragmented to come in this computer's NIC.
>
> (5) If sendmsg() is given MSG_MORE then it should allocate an skb of the
> maximum size rather than one just big enough for the data it's got left
> to process on the theory that there is more data to come that it can
> append to that packet.
>
> This means, for example, that if AFS does a large StoreData op, all the
> packets barring the last will be filled to the maximum unfragmented size.
>
> Signed-off-by: David Howells <dhowells@redhat.com>
Applied, thanks.
prev parent reply other threads:[~2007-05-04 19:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-04 14:56 [PATCH] AF_RXRPC: Sort out MTU handling David Howells
2007-05-04 19:42 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070504.124225.111205875.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).