From mboxrd@z Thu Jan 1 00:00:00 1970 From: Josef Sipek Subject: Re: [PATCH 1/2] fs: Fix indentation in do_path_lookup Date: Sun, 6 May 2007 12:43:23 -0400 Message-ID: <20070506164323.GA11170@filer.fsl.cs.sunysb.edu> References: <1178405980972-git-send-email-jsipek@cs.sunysb.edu> <11784059803717-git-send-email-jsipek@cs.sunysb.edu> <20070506111124.GA1211@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii To: Christoph Hellwig , "Josef 'Jeff' Sipek" , torvalds@linux-foundation.org, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Return-path: Received: from filer.fsl.cs.sunysb.edu ([130.245.126.2]:58246 "EHLO filer.fsl.cs.sunysb.edu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753023AbXEFQnk (ORCPT ); Sun, 6 May 2007 12:43:40 -0400 Content-Disposition: inline In-Reply-To: <20070506111124.GA1211@infradead.org> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Sun, May 06, 2007 at 12:11:24PM +0100, Christoph Hellwig wrote: > On Sat, May 05, 2007 at 06:59:39PM -0400, Josef 'Jeff' Sipek wrote: > > Signed-off-by: Josef 'Jeff' Sipek > > --- > > fs/namei.c | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/fs/namei.c b/fs/namei.c > > index 0262594..600a4e7 100644 > > --- a/fs/namei.c > > +++ b/fs/namei.c > > @@ -1159,7 +1159,7 @@ out: > > if (likely(retval == 0)) { > > if (unlikely(!audit_dummy_context() && nd && nd->dentry && > > nd->dentry->d_inode)) > > - audit_inode(name, nd->dentry->d_inode); > > + audit_inode(name, nd->dentry->d_inode); > > } ... > nd is guaranteed to be zero. Should that say non-zero? Josef "Jeff" Sipek. -- Humans were created by water to transport it upward.