From: Christoph Hellwig <hch@infradead.org>
To: Josef Sipek <jsipek@fsl.cs.sunysb.edu>
Cc: Christoph Hellwig <hch@infradead.org>,
Josef 'Jeff' Sipek <jsipek@cs.sunysb.edu>,
torvalds@linux-foundation.org, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 1/2] fs: Fix indentation in do_path_lookup
Date: Sun, 6 May 2007 17:49:50 +0100 [thread overview]
Message-ID: <20070506164950.GA7204@infradead.org> (raw)
In-Reply-To: <20070506164323.GA11170@filer.fsl.cs.sunysb.edu>
On Sun, May 06, 2007 at 12:43:23PM -0400, Josef Sipek wrote:
> On Sun, May 06, 2007 at 12:11:24PM +0100, Christoph Hellwig wrote:
> > On Sat, May 05, 2007 at 06:59:39PM -0400, Josef 'Jeff' Sipek wrote:
> > > Signed-off-by: Josef 'Jeff' Sipek <jsipek@cs.sunysb.edu>
> > > ---
> > > fs/namei.c | 2 +-
> > > 1 files changed, 1 insertions(+), 1 deletions(-)
> > >
> > > diff --git a/fs/namei.c b/fs/namei.c
> > > index 0262594..600a4e7 100644
> > > --- a/fs/namei.c
> > > +++ b/fs/namei.c
> > > @@ -1159,7 +1159,7 @@ out:
> > > if (likely(retval == 0)) {
> > > if (unlikely(!audit_dummy_context() && nd && nd->dentry &&
> > > nd->dentry->d_inode))
> > > - audit_inode(name, nd->dentry->d_inode);
> > > + audit_inode(name, nd->dentry->d_inode);
> > > }
> ...
> > nd is guaranteed to be zero.
>
> Should that say non-zero?
Yes, sorry.
next prev parent reply other threads:[~2007-05-06 16:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-05 22:59 [PATCH 0/2] [TRIVIAL] Small cleanups for do_path_lookup Josef 'Jeff' Sipek
2007-05-05 22:59 ` [PATCH 1/2] fs: Fix indentation in do_path_lookup Josef 'Jeff' Sipek
2007-05-06 11:11 ` Christoph Hellwig
2007-05-06 15:30 ` [PATCH] " Josef 'Jeff' Sipek
2007-05-06 16:21 ` Christoph Hellwig
2007-05-06 16:43 ` [PATCH 1/2] " Josef Sipek
2007-05-06 16:49 ` Christoph Hellwig [this message]
2007-05-05 22:59 ` [PATCH 2/2] fs: Use path_walk " Josef 'Jeff' Sipek
2007-05-06 11:11 ` Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2007-05-06 17:47 [PATCH 0/2] [TRIVIAL] Small cleanups for do_path_lookup (V2) Josef 'Jeff' Sipek
2007-05-06 17:47 ` [PATCH 1/2] fs: Fix indentation in do_path_lookup Josef 'Jeff' Sipek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070506164950.GA7204@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=jsipek@cs.sunysb.edu \
--cc=jsipek@fsl.cs.sunysb.edu \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).