linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Valerie Henson <val_henson@linux.intel.com>
To: Matt Mackall <mpm@selenic.com>
Cc: Theodore Tso <tytso@mit.edu>, linux-fsdevel@vger.kernel.org
Subject: Re: [RFC] TileFS - a proposal for scalable integrity checking
Date: Wed, 9 May 2007 00:56:39 -0700	[thread overview]
Message-ID: <20070509075638.GJ12859@nifty> (raw)
In-Reply-To: <20070430014042.GL11115@waste.org>

On Sun, Apr 29, 2007 at 08:40:42PM -0500, Matt Mackall wrote:
> 
> This does mean that our time to make progress on a check is bounded at
> the top by the size of our largest file. If we have a degenerate
> filesystem filled with a single file, this will in fact take as long
> as a conventional fsck. If your filesystem has, say, 100 roughly
> equally-sized files, you're back in Chunkfs territory.

Hm, I'm not sure that everyone understands, a particular subtlety of
how the fsck algorithm works in chunkfs.  A lot of people seem to
think that you need to check *all* cross-chunk links, every time an
individual chunk is checked.  That's not the case; you only need to
check the links that go into and out of the dirty chunk.  You also
don't need to check the other parts of the file outside the chunk,
except for perhaps reading the byte range info for each continuation
node and making sure no two continuation inodes think they both have
the same range, but you don't check the indirect blocks, block
bitmaps, etc.

There is one case where you do need to do a full check of all links
that cross chunks - if a continuation inode's pointers have been
corrupted, and you might end up with orphan continuation inodes or
dangling links in other chunks.  I expect that to be relatively rare.

> So we should have no trouble checking an exabyte-sized filesystem on a
> 4MB box. Even if it has one exabyte-sized file! We check the first
> tile, see that it points to our file, then iterate through that file,
> checking that the forward and reverse pointers for each block match
> and all CRCs match, etc. We cache the file's inode as clean, finish
> checking anything else in the first tile, then mark it clean. When we get
> to the next tile (and the next billion after that!), we notice that
> each block points back to our cached inode and skip rechecking it.

If I understand correctly then, if you do have a one exabyte sized
file, and any part of it is in a dirty tile, you will need to check
the whole file?  Or will Joern's fpos proposal fix this?

This is interesting stuff, thanks!

-VAL

  parent reply	other threads:[~2007-05-09  7:56 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-28 22:05 [RFC] TileFS - a proposal for scalable integrity checking Matt Mackall
2007-04-29 12:21 ` Jörn Engel
2007-04-29 12:57   ` Matt Mackall
2007-04-29 15:47     ` Jörn Engel
2007-05-09  5:56   ` Valerie Henson
2007-05-09 10:12     ` Jörn Engel
2007-04-29 15:58 ` Jörn Engel
2007-04-29 16:24   ` Matt Mackall
2007-04-29 16:34 ` Andi Kleen
2007-04-29 16:05   ` Jörn Engel
2007-04-29 16:09   ` Matt Mackall
2007-04-29 23:23 ` Theodore Tso
2007-04-30  1:40   ` Matt Mackall
2007-04-30 17:26     ` Theodore Tso
2007-04-30 17:59       ` Matt Mackall
2007-05-02 13:18         ` Jörn Engel
2007-05-02 13:32     ` Jörn Engel
2007-05-02 15:37       ` Matt Mackall
2007-05-02 16:35         ` Jörn Engel
2007-05-09  7:56     ` Valerie Henson [this message]
2007-05-09 11:16       ` Nikita Danilov
2007-05-09 18:56         ` Valerie Henson
2007-05-09 19:19           ` Nikita Danilov
2007-05-09 17:06       ` Matt Mackall
2007-05-09 18:59         ` Valerie Henson
2007-05-09 19:51           ` Matt Mackall
2007-05-10  0:03             ` Jörn Engel
2007-05-11  9:46             ` Valerie Henson
2007-05-11 15:55               ` Matt Mackall
2007-05-09 19:01     ` Valerie Henson
2007-05-09 20:05       ` Matt Mackall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070509075638.GJ12859@nifty \
    --to=val_henson@linux.intel.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=mpm@selenic.com \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).