From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Subject: Re: [PATCH 1/2] AFS: Fix interminable loop in afs_write_back_from_locked_page() Date: Fri, 11 May 2007 02:58:22 -0700 Message-ID: <20070511025822.a5aa5240.akpm@linux-foundation.org> References: <20070510161946.96ff0784.akpm@linux-foundation.org> <20070510143334.19485.26042.stgit@warthog.cambridge.redhat.com> <8792.1178876963@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org To: David Howells Return-path: In-Reply-To: <8792.1178876963@redhat.com> Sender: netdev-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Fri, 11 May 2007 10:49:23 +0100 David Howells wrote: > Andrew Morton wrote: > > > > Following bug was uncovered by compiling with '-W' flag: > > > > gcc -W finds a number of fairly scary bugs. > > Do you mean in my code specifically? Or in the kernel in general? In general. > As far as > I can tell -W only finds an eye-glazingly large quantity of 'unused parameter' > warnings in AFS and AF_RXRPC. Yes, it's a shame that there doesn't seem to be a fine-grained way of turning on -W's useful bits.