linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: npiggin@suse.de
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-fsdevel@vger.kernel.org,
	Linux Memory Management <linux-mm@kvack.org>,
	Andrew Morton <akpm@osdl.org>
Subject: [patch 02/41] Revert 81b0c8713385ce1b1b9058e916edcf9561ad76d6
Date: Mon, 14 May 2007 16:06:21 +1000	[thread overview]
Message-ID: <20070514060650.231658000@wotan.suse.de> (raw)
In-Reply-To: 20070514060619.689648000@wotan.suse.de

[-- Attachment #1: mm-revert-buffered-write-zero-length-iov.patch --]
[-- Type: text/plain, Size: 1660 bytes --]

From: Andrew Morton <akpm@osdl.org>

This was a bugfix against 6527c2bdf1f833cc18e8f42bd97973d583e4aa83, which we
also revert.

Cc: Linux Memory Management <linux-mm@kvack.org>
Cc: Linux Filesystems <linux-fsdevel@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Nick Piggin <npiggin@suse.de>

 mm/filemap.c |    9 +--------
 mm/filemap.h |    4 ++--
 2 files changed, 3 insertions(+), 10 deletions(-)

Index: linux-2.6/mm/filemap.c
===================================================================
--- linux-2.6.orig/mm/filemap.c
+++ linux-2.6/mm/filemap.c
@@ -1957,12 +1957,6 @@ generic_file_buffered_write(struct kiocb
 			break;
 		}
 
-		if (unlikely(bytes == 0)) {
-			status = 0;
-			copied = 0;
-			goto zero_length_segment;
-		}
-
 		status = a_ops->prepare_write(file, page, offset, offset+bytes);
 		if (unlikely(status)) {
 			loff_t isize = i_size_read(inode);
@@ -1992,8 +1986,7 @@ generic_file_buffered_write(struct kiocb
 			page_cache_release(page);
 			continue;
 		}
-zero_length_segment:
-		if (likely(copied >= 0)) {
+		if (likely(copied > 0)) {
 			if (!status)
 				status = copied;
 
Index: linux-2.6/mm/filemap.h
===================================================================
--- linux-2.6.orig/mm/filemap.h
+++ linux-2.6/mm/filemap.h
@@ -87,7 +87,7 @@ filemap_set_next_iovec(const struct iove
 	const struct iovec *iov = *iovp;
 	size_t base = *basep;
 
-	do {
+	while (bytes) {
 		int copy = min(bytes, iov->iov_len - base);
 
 		bytes -= copy;
@@ -96,7 +96,7 @@ filemap_set_next_iovec(const struct iove
 			iov++;
 			base = 0;
 		}
-	} while (bytes);
+	}
 	*iovp = iov;
 	*basep = base;
 }

-- 


  parent reply	other threads:[~2007-05-14  8:23 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-14  6:06 [patch 00/41] Buffered write deadlock fix and new aops for 2.6.21-mm2 npiggin
2007-05-14  6:06 ` [patch 01/41] mm: revert KERNEL_DS buffered write optimisation npiggin
2007-05-14  6:06 ` npiggin [this message]
2007-05-14 19:06   ` [patch 02/41] Revert 81b0c8713385ce1b1b9058e916edcf9561ad76d6 Dave Jones
2007-05-14 22:45     ` Nick Piggin
2007-05-14  6:06 ` [patch 03/41] Revert 6527c2bdf1f833cc18e8f42bd97973d583e4aa83 npiggin
2007-05-14  6:06 ` [patch 04/41] mm: clean up buffered write code npiggin
2007-05-14  6:06 ` [patch 05/41] mm: debug write deadlocks npiggin
2007-05-14  6:06 ` [patch 06/41] mm: trim more holes npiggin
2007-05-14  6:06 ` [patch 07/41] mm: buffered write cleanup npiggin
2007-05-14  6:06 ` [patch 08/41] mm: write iovec cleanup npiggin
2007-05-14  6:06 ` [patch 09/41] mm: fix pagecache write deadlocks npiggin
2007-05-14  6:06 ` [patch 10/41] mm: buffered write iterator npiggin
2007-05-14  6:06 ` [patch 11/41] fs: fix data-loss on error npiggin
2007-05-14  6:06 ` [patch 12/41] fs: introduce write_begin, write_end, and perform_write aops npiggin
2007-05-14  6:06 ` [patch 13/41] mm: restore KERNEL_DS optimisations npiggin
2007-05-14  6:06 ` [patch 14/41] implement simple fs aops npiggin
2007-05-14  6:06 ` [patch 15/41] block_dev convert to new aops npiggin
2007-05-14  6:06 ` [patch 16/41] rd " npiggin
2007-05-14  6:06 ` [patch 17/41] ext2 " npiggin
2007-05-16 12:45   ` Nick Piggin
2007-05-14  6:06 ` [patch 18/41] ext3 " npiggin
2007-05-14  6:06 ` [patch 19/41] ext4 " npiggin
2007-05-14  6:06 ` [patch 20/41] xfs " npiggin
2007-05-14  6:06 ` [patch 21/41] fs: new cont helpers npiggin
2007-05-14  6:06 ` [patch 22/41] fat convert to new aops npiggin
2007-05-14  6:06 ` [patch 23/41] adfs " npiggin
2007-05-14  6:06 ` [patch 24/41] hfs " npiggin
2007-05-14  6:06 ` [patch 25/41] hfsplus " npiggin
2007-05-14  6:06 ` [patch 26/41] hpfs " npiggin
2007-05-14  6:06 ` [patch 27/41] bfs " npiggin
2007-05-14  6:06 ` [patch 28/41] qnx4 " npiggin
2007-05-14 10:37   ` Anders Larsen
2007-05-14  6:06 ` [patch 29/41] reiserfs use generic write npiggin
2007-05-14  6:06 ` [patch 30/41] reiserfs convert to new aops npiggin
2007-05-14  6:06 ` [patch 31/41] nfs " npiggin
2007-05-14  6:06 ` [patch 32/41] smb " npiggin
2007-05-14  6:06 ` [patch 33/41] GFS2 " npiggin
2007-05-14  6:06 ` [patch 34/41] fuse " npiggin
2007-05-14  6:06 ` [patch 35/41] hostfs " npiggin
2007-05-14  6:06 ` [patch 36/41] jffs2 " npiggin
2007-05-14  6:06 ` [patch 37/41] ufs " npiggin
2007-05-14  6:06 ` [patch 38/41] udf " npiggin
2007-05-14  6:06 ` [patch 39/41] sysv " npiggin
2007-05-14  6:06 ` [patch 40/41] minix " npiggin
2007-05-14  6:07 ` [patch 41/41] jfs " npiggin
     [not found] ` <200705142014.27237.vs@namesys.com>
     [not found]   ` <20070514224042.GD5531@wotan.suse.de>
2007-05-16 17:22     ` [patch 30/41] reiserfs " Vladimir V. Saveliev
  -- strict thread matches above, loose matches on Subject: below --
2007-05-25 12:21 [patch 00/41] Buffered write deadlock fix and new aops for 2.6.22-rc2-mm1 npiggin
2007-05-25 12:21 ` [patch 02/41] Revert 81b0c8713385ce1b1b9058e916edcf9561ad76d6 npiggin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070514060650.231658000@wotan.suse.de \
    --to=npiggin@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=akpm@osdl.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).