From: npiggin@suse.de
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-fsdevel@vger.kernel.org, zippel@linux-m68k.org
Subject: [patch 24/41] hfs convert to new aops.
Date: Mon, 14 May 2007 16:06:43 +1000 [thread overview]
Message-ID: <20070514060653.672205000@wotan.suse.de> (raw)
In-Reply-To: 20070514060619.689648000@wotan.suse.de
[-- Attachment #1: fs-hfs-aops.patch --]
[-- Type: text/plain, Size: 3099 bytes --]
Cc: zippel@linux-m68k.org
Cc: Linux Filesystems <linux-fsdevel@vger.kernel.org>
Signed-off-by: Nick Piggin <npiggin@suse.de>
fs/hfs/extent.c | 19 ++++++++-----------
fs/hfs/inode.c | 20 ++++++++++++--------
2 files changed, 20 insertions(+), 19 deletions(-)
Index: linux-2.6/fs/hfs/inode.c
===================================================================
--- linux-2.6.orig/fs/hfs/inode.c
+++ linux-2.6/fs/hfs/inode.c
@@ -34,10 +34,14 @@ static int hfs_readpage(struct file *fil
return block_read_full_page(page, hfs_get_block);
}
-static int hfs_prepare_write(struct file *file, struct page *page, unsigned from, unsigned to)
-{
- return cont_prepare_write(page, from, to, hfs_get_block,
- &HFS_I(page->mapping->host)->phys_size);
+static int hfs_write_begin(struct file *file, struct address_space *mapping,
+ loff_t pos, unsigned len, unsigned flags,
+ struct page **pagep, void **fsdata)
+{
+ *pagep = NULL;
+ return cont_write_begin(file, mapping, pos, len, flags, pagep, fsdata,
+ hfs_get_block,
+ &HFS_I(mapping->host)->phys_size);
}
static sector_t hfs_bmap(struct address_space *mapping, sector_t block)
@@ -118,8 +122,8 @@ const struct address_space_operations hf
.readpage = hfs_readpage,
.writepage = hfs_writepage,
.sync_page = block_sync_page,
- .prepare_write = hfs_prepare_write,
- .commit_write = generic_commit_write,
+ .write_begin = hfs_write_begin,
+ .write_end = generic_write_end,
.bmap = hfs_bmap,
.releasepage = hfs_releasepage,
};
@@ -128,8 +132,8 @@ const struct address_space_operations hf
.readpage = hfs_readpage,
.writepage = hfs_writepage,
.sync_page = block_sync_page,
- .prepare_write = hfs_prepare_write,
- .commit_write = generic_commit_write,
+ .write_begin = hfs_write_begin,
+ .write_end = generic_write_end,
.bmap = hfs_bmap,
.direct_IO = hfs_direct_IO,
.writepages = hfs_writepages,
Index: linux-2.6/fs/hfs/extent.c
===================================================================
--- linux-2.6.orig/fs/hfs/extent.c
+++ linux-2.6/fs/hfs/extent.c
@@ -464,23 +464,20 @@ void hfs_file_truncate(struct inode *ino
(long long)HFS_I(inode)->phys_size, inode->i_size);
if (inode->i_size > HFS_I(inode)->phys_size) {
struct address_space *mapping = inode->i_mapping;
+ void *fsdata;
struct page *page;
int res;
+ /* XXX: Can use generic_cont_expand? */
size = inode->i_size - 1;
- page = grab_cache_page(mapping, size >> PAGE_CACHE_SHIFT);
- if (!page)
- return;
- size &= PAGE_CACHE_SIZE - 1;
- size++;
- res = mapping->a_ops->prepare_write(NULL, page, size, size);
- if (!res)
- res = mapping->a_ops->commit_write(NULL, page, size, size);
+ res = pagecache_write_begin(NULL, mapping, size+1, 0,
+ AOP_FLAG_UNINTERRUPTIBLE, &page, &fsdata);
+ if (!res) {
+ res = pagecache_write_end(NULL, mapping, size+1, 0, 0,
+ page, fsdata);
+ }
if (res)
inode->i_size = HFS_I(inode)->phys_size;
- unlock_page(page);
- page_cache_release(page);
- mark_inode_dirty(inode);
return;
} else if (inode->i_size == HFS_I(inode)->phys_size)
return;
--
next prev parent reply other threads:[~2007-05-14 8:24 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-14 6:06 [patch 00/41] Buffered write deadlock fix and new aops for 2.6.21-mm2 npiggin
2007-05-14 6:06 ` [patch 01/41] mm: revert KERNEL_DS buffered write optimisation npiggin
2007-05-14 6:06 ` [patch 02/41] Revert 81b0c8713385ce1b1b9058e916edcf9561ad76d6 npiggin
2007-05-14 19:06 ` Dave Jones
2007-05-14 22:45 ` Nick Piggin
2007-05-14 6:06 ` [patch 03/41] Revert 6527c2bdf1f833cc18e8f42bd97973d583e4aa83 npiggin
2007-05-14 6:06 ` [patch 04/41] mm: clean up buffered write code npiggin
2007-05-14 6:06 ` [patch 05/41] mm: debug write deadlocks npiggin
2007-05-14 6:06 ` [patch 06/41] mm: trim more holes npiggin
2007-05-14 6:06 ` [patch 07/41] mm: buffered write cleanup npiggin
2007-05-14 6:06 ` [patch 08/41] mm: write iovec cleanup npiggin
2007-05-14 6:06 ` [patch 09/41] mm: fix pagecache write deadlocks npiggin
2007-05-14 6:06 ` [patch 10/41] mm: buffered write iterator npiggin
2007-05-14 6:06 ` [patch 11/41] fs: fix data-loss on error npiggin
2007-05-14 6:06 ` [patch 12/41] fs: introduce write_begin, write_end, and perform_write aops npiggin
2007-05-14 6:06 ` [patch 13/41] mm: restore KERNEL_DS optimisations npiggin
2007-05-14 6:06 ` [patch 14/41] implement simple fs aops npiggin
2007-05-14 6:06 ` [patch 15/41] block_dev convert to new aops npiggin
2007-05-14 6:06 ` [patch 16/41] rd " npiggin
2007-05-14 6:06 ` [patch 17/41] ext2 " npiggin
2007-05-16 12:45 ` Nick Piggin
2007-05-14 6:06 ` [patch 18/41] ext3 " npiggin
2007-05-14 6:06 ` [patch 19/41] ext4 " npiggin
2007-05-14 6:06 ` [patch 20/41] xfs " npiggin
2007-05-14 6:06 ` [patch 21/41] fs: new cont helpers npiggin
2007-05-14 6:06 ` [patch 22/41] fat convert to new aops npiggin
2007-05-14 6:06 ` [patch 23/41] adfs " npiggin
2007-05-14 6:06 ` npiggin [this message]
2007-05-14 6:06 ` [patch 25/41] hfsplus " npiggin
2007-05-14 6:06 ` [patch 26/41] hpfs " npiggin
2007-05-14 6:06 ` [patch 27/41] bfs " npiggin
2007-05-14 6:06 ` [patch 28/41] qnx4 " npiggin
2007-05-14 10:37 ` Anders Larsen
2007-05-14 6:06 ` [patch 29/41] reiserfs use generic write npiggin
2007-05-14 6:06 ` [patch 30/41] reiserfs convert to new aops npiggin
2007-05-14 6:06 ` [patch 31/41] nfs " npiggin
2007-05-14 6:06 ` [patch 32/41] smb " npiggin
2007-05-14 6:06 ` [patch 33/41] GFS2 " npiggin
2007-05-14 6:06 ` [patch 34/41] fuse " npiggin
2007-05-14 6:06 ` [patch 35/41] hostfs " npiggin
2007-05-14 6:06 ` [patch 36/41] jffs2 " npiggin
2007-05-14 6:06 ` [patch 37/41] ufs " npiggin
2007-05-14 6:06 ` [patch 38/41] udf " npiggin
2007-05-14 6:06 ` [patch 39/41] sysv " npiggin
2007-05-14 6:06 ` [patch 40/41] minix " npiggin
2007-05-14 6:07 ` [patch 41/41] jfs " npiggin
[not found] ` <200705142014.27237.vs@namesys.com>
[not found] ` <20070514224042.GD5531@wotan.suse.de>
2007-05-16 17:22 ` [patch 30/41] reiserfs " Vladimir V. Saveliev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070514060653.672205000@wotan.suse.de \
--to=npiggin@suse.de \
--cc=akpm@linux-foundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).