From: Bharata B Rao <bharata@linux.vnet.ibm.com>
To: linux-kernel@vger.kernel.org
Cc: linux-fsdevel@vger.kernel.org, Jan Blunck <j.blunck@tu-harburg.de>
Subject: [RFC][PATCH 12/14] ext2 whiteout support
Date: Mon, 14 May 2007 15:14:27 +0530 [thread overview]
Message-ID: <20070514094427.GN4139@in.ibm.com> (raw)
In-Reply-To: <20070514093722.GB4139@in.ibm.com>
From: Jan Blunck <j.blunck@tu-harburg.de>
Subject: ext2 whiteout support
Introduce whiteout support to ext2.
Signed-off-by: Jan Blunck <j.blunck@tu-harburg.de>
Signed-off-by: Bharata B Rao <bharata@linux.vnet.ibm.com>
---
fs/ext2/dir.c | 2 ++
fs/ext2/namei.c | 17 +++++++++++++++++
fs/ext2/super.c | 11 ++++++++++-
include/linux/ext2_fs.h | 4 ++++
4 files changed, 33 insertions(+), 1 deletion(-)
--- a/fs/ext2/dir.c
+++ b/fs/ext2/dir.c
@@ -218,6 +218,7 @@ static unsigned char ext2_filetype_table
[EXT2_FT_FIFO] = DT_FIFO,
[EXT2_FT_SOCK] = DT_SOCK,
[EXT2_FT_SYMLINK] = DT_LNK,
+ [EXT2_FT_WHT] = DT_WHT,
};
#define S_SHIFT 12
@@ -229,6 +230,7 @@ static unsigned char ext2_type_by_mode[S
[S_IFIFO >> S_SHIFT] = EXT2_FT_FIFO,
[S_IFSOCK >> S_SHIFT] = EXT2_FT_SOCK,
[S_IFLNK >> S_SHIFT] = EXT2_FT_SYMLINK,
+ [S_IFWHT >> S_SHIFT] = EXT2_FT_WHT,
};
static inline void ext2_set_de_type(ext2_dirent *de, struct inode *inode)
--- a/fs/ext2/namei.c
+++ b/fs/ext2/namei.c
@@ -288,6 +288,22 @@ static int ext2_rmdir (struct inode * di
return err;
}
+static int ext2_whiteout(struct inode *dir, struct dentry *dentry)
+{
+ struct inode *inode;
+ int err;
+
+ inode = ext2_new_inode (dir, S_IFWHT | S_IRUGO);
+ err = PTR_ERR(inode);
+ if (IS_ERR(inode))
+ goto out;
+
+ mark_inode_dirty(inode);
+ err = ext2_add_nondir(dentry, inode);
+out:
+ return err;
+}
+
static int ext2_rename (struct inode * old_dir, struct dentry * old_dentry,
struct inode * new_dir, struct dentry * new_dentry )
{
@@ -382,6 +398,7 @@ const struct inode_operations ext2_dir_i
.mkdir = ext2_mkdir,
.rmdir = ext2_rmdir,
.mknod = ext2_mknod,
+ .whiteout = ext2_whiteout,
.rename = ext2_rename,
#ifdef CONFIG_EXT2_FS_XATTR
.setxattr = generic_setxattr,
--- a/fs/ext2/super.c
+++ b/fs/ext2/super.c
@@ -754,6 +754,15 @@ static int ext2_fill_super(struct super_
ext2_xip_verify_sb(sb); /* see if bdev supports xip, unset
EXT2_MOUNT_XIP if not */
+ if ((sb->s_flags & MS_UNION) && !(sb->s_flags & MS_RDONLY)) {
+ if (!EXT2_HAS_INCOMPAT_FEATURE(sb,
+ EXT2_FEATURE_INCOMPAT_WHITEOUT)) {
+ sb->s_flags |= MS_RDONLY;
+ ext2_warning(sb, __FUNCTION__,
+ "no whiteout support, mounting filesystem read-only");
+ }
+ }
+
if (le32_to_cpu(es->s_rev_level) == EXT2_GOOD_OLD_REV &&
(EXT2_HAS_COMPAT_FEATURE(sb, ~0U) ||
EXT2_HAS_RO_COMPAT_FEATURE(sb, ~0U) ||
@@ -1292,7 +1301,7 @@ static struct file_system_type ext2_fs_t
.name = "ext2",
.get_sb = ext2_get_sb,
.kill_sb = kill_block_super,
- .fs_flags = FS_REQUIRES_DEV,
+ .fs_flags = FS_REQUIRES_DEV | FS_WHT,
};
static int __init init_ext2_fs(void)
--- a/include/linux/ext2_fs.h
+++ b/include/linux/ext2_fs.h
@@ -61,6 +61,7 @@
#define EXT2_ROOT_INO 2 /* Root inode */
#define EXT2_BOOT_LOADER_INO 5 /* Boot loader inode */
#define EXT2_UNDEL_DIR_INO 6 /* Undelete directory inode */
+#define EXT2_WHT_INO 7 /* Whiteout inode */
/* First non-reserved inode for old ext2 filesystems */
#define EXT2_GOOD_OLD_FIRST_INO 11
@@ -479,10 +480,12 @@ struct ext2_super_block {
#define EXT3_FEATURE_INCOMPAT_RECOVER 0x0004
#define EXT3_FEATURE_INCOMPAT_JOURNAL_DEV 0x0008
#define EXT2_FEATURE_INCOMPAT_META_BG 0x0010
+#define EXT2_FEATURE_INCOMPAT_WHITEOUT 0x0020
#define EXT2_FEATURE_INCOMPAT_ANY 0xffffffff
#define EXT2_FEATURE_COMPAT_SUPP EXT2_FEATURE_COMPAT_EXT_ATTR
#define EXT2_FEATURE_INCOMPAT_SUPP (EXT2_FEATURE_INCOMPAT_FILETYPE| \
+ EXT2_FEATURE_INCOMPAT_WHITEOUT| \
EXT2_FEATURE_INCOMPAT_META_BG)
#define EXT2_FEATURE_RO_COMPAT_SUPP (EXT2_FEATURE_RO_COMPAT_SPARSE_SUPER| \
EXT2_FEATURE_RO_COMPAT_LARGE_FILE| \
@@ -549,6 +552,7 @@ enum {
EXT2_FT_FIFO,
EXT2_FT_SOCK,
EXT2_FT_SYMLINK,
+ EXT2_FT_WHT,
EXT2_FT_MAX
};
next prev parent reply other threads:[~2007-05-14 9:36 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-14 9:37 [RFC][PATCH 0/14] VFS based Union Mount(v1) Bharata B Rao
2007-05-14 9:38 ` [RFC][PATCH 1/14] Add union mount documentation Bharata B Rao
2007-05-14 9:39 ` [RFC][PATCH 2/14] Add a new mount flag (MNT_UNION) for union mount Bharata B Rao
2007-05-14 20:38 ` Jan Engelhardt
2007-05-15 8:16 ` Bharata B Rao
2007-05-15 12:06 ` Eric Van Hensbergen
2007-05-15 12:53 ` Jan Blunck
2007-05-14 9:39 ` [RFC][PATCH 3/14] Add the whiteout file type Bharata B Rao
2007-05-14 20:39 ` Jan Engelhardt
2007-05-15 6:00 ` Jan Blunck
2007-05-14 9:40 ` [RFC][PATCH 4/14] Add config options for union mount Bharata B Rao
2007-05-14 9:40 ` [RFC][PATCH 5/14] Introduce union stack Bharata B Rao
2007-05-14 20:23 ` Badari Pulavarty
2007-05-14 20:51 ` Jan Engelhardt
2007-05-19 10:18 ` Paul Dickson
2007-05-22 16:35 ` Jan Engelhardt
2007-05-23 13:25 ` Serge E. Hallyn
2007-05-14 20:48 ` Jan Engelhardt
2007-05-15 7:19 ` Jan Blunck
2007-05-14 22:40 ` Badari Pulavarty
2007-05-15 6:28 ` Bharata B Rao
2007-05-14 9:41 ` [RFC][PATCH 6/14] Union-mount dentry reference counting Bharata B Rao
2007-05-14 20:57 ` Jan Engelhardt
2007-05-14 9:41 ` [RFC][PATCH 7/14] Union-mount mounting Bharata B Rao
2007-05-15 7:29 ` Jan Engelhardt
2007-05-16 5:04 ` Bharata B Rao
2007-05-14 9:42 ` [RFC][PATCH 8/14] Union-mount lookup Bharata B Rao
2007-05-15 7:57 ` Jan Engelhardt
2007-05-16 5:08 ` Bharata B Rao
2007-05-16 19:28 ` Jan Engelhardt
2007-05-16 20:06 ` Serge E. Hallyn
2007-05-15 14:00 ` Trond Myklebust
2007-05-18 11:05 ` Bharata B Rao
2007-05-14 9:42 ` [RFC][PATCH 9/14] Union-mount readdir Bharata B Rao
2007-05-14 10:43 ` Carsten Otte
2007-05-14 11:15 ` Bharata B Rao
2007-05-14 9:43 ` [RFC][PATCH 10/14] In-kernel file copy between union mounted filesystems Bharata B Rao
2007-05-16 7:57 ` Jan Engelhardt
2007-05-18 11:10 ` Bharata B Rao
2007-05-18 13:47 ` Shaya Potter
2007-05-22 3:13 ` Bharata B Rao
2007-05-22 6:25 ` Jan Engelhardt
2007-05-22 8:38 ` Bharata B Rao
2007-05-22 12:35 ` Shaya Potter
2007-05-23 10:41 ` Bharata B Rao
2007-05-14 9:43 ` [RFC][PATCH 11/14] VFS whiteout handling Bharata B Rao
2007-05-16 8:06 ` Jan Engelhardt
2007-05-14 9:44 ` Bharata B Rao [this message]
2007-05-16 8:07 ` [RFC][PATCH 12/14] ext2 whiteout support Jan Engelhardt
2007-05-14 9:44 ` [RFC][PATCH 13/14] ext3 " Bharata B Rao
2007-05-14 20:16 ` Badari Pulavarty
2007-05-15 6:26 ` Bharata B Rao
2007-05-15 8:31 ` Jan Blunck
2007-05-14 20:17 ` Andreas Dilger
2007-05-14 20:35 ` Jan Blunck
2007-05-15 14:28 ` Theodore Tso
2007-05-14 9:45 ` [RFC][PATCH 14/14] tmpfs " Bharata B Rao
2007-05-14 16:13 ` Hugh Dickins
2007-05-14 19:20 ` Jan Blunck
2007-05-14 19:35 ` Hugh Dickins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070514094427.GN4139@in.ibm.com \
--to=bharata@linux.vnet.ibm.com \
--cc=j.blunck@tu-harburg.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).