From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sam Ravnborg Subject: Re: [PATCH] LogFS take three Date: Tue, 15 May 2007 20:37:25 +0200 Message-ID: <20070515183725.GA22003@uranus.ravnborg.org> References: <20070515151919.GA32510@lazybastard.org> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org, akpm@osdl.org, Albert Cahalan , Thomas Gleixner , Jan Engelhardt , Evgeniy Polyakov , Pekka Enberg , Greg KH , Ingo Oeser To: =?iso-8859-1?Q?J=F6rn?= Engel Return-path: Received: from pasmtpa.tele.dk ([80.160.77.114]:46145 "EHLO pasmtpA.tele.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754948AbXEOSga (ORCPT ); Tue, 15 May 2007 14:36:30 -0400 Content-Disposition: inline In-Reply-To: <20070515151919.GA32510@lazybastard.org> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Tue, May 15, 2007 at 05:19:20PM +0200, J=F6rn Engel wrote: > [ I have put everyone that gave comments to the last patch on Cc:. H= ope > that doesn't offend anyone. ] >=20 >=20 > Add LogFS, a scalable flash filesystem. Have you run sparse on this code? I do not recall if you have written something about it. I do not see any obvious things sparse would catch (just browsing quick= ly) but it's always a good thing to do. =20 +++ linux-2.6.21logfs/fs/logfs/progs/fsck.c 2007-05-15 00:54:22.000= 000000 +0200 @@ -0,0 +1,332 @@ +/* + * fs/logfs/prog/fsck.c - filesystem check + * + * As should be obvious for Linux kernel code, license is GPLv2 + * + * Copyright (c) 2005-2007 Joern Engel + * + * In principle this could get moved to userspace. However it might s= till + * make some sense to keep it in the kernel. It is a pure checker and= will + * only report problems, not attempt to repair them. + */ +#include "../logfs.h" + If potential userspace tools needs to include ../logfs.h then there is something that ought to be moved to include/linux/logfs.h instead. Sam - To unsubscribe from this list: send the line "unsubscribe linux-fsdevel= " in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html