From: "Serge E. Hallyn" <serue@us.ibm.com>
To: Jan Engelhardt <jengelh@linux01.gwdg.de>
Cc: Bharata B Rao <bharata@linux.vnet.ibm.com>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Jan Blunck <j.blunck@tu-harburg.de>
Subject: Re: [RFC][PATCH 8/14] Union-mount lookup
Date: Wed, 16 May 2007 15:06:47 -0500 [thread overview]
Message-ID: <20070516200647.GA8961@sergelap.austin.ibm.com> (raw)
In-Reply-To: <Pine.LNX.4.61.0705162127080.9019@yvahk01.tjqt.qr>
Quoting Jan Engelhardt (jengelh@linux01.gwdg.de):
>
> On May 16 2007 10:38, Bharata B Rao wrote:
> >>
> >> >+lookup_union:
> >> >+ do {
> >> >+ struct vfsmount *mnt = find_mnt(topmost);
> >> >+ UM_DEBUG_DCACHE("name=\"%s\", inode=%p, device=%s\n",
> >> >+ topmost->d_name.name, topmost->d_inode,
> >> >+ mnt->mnt_devname);
> >> >+ mntput(mnt);
> >> >+ } while (0);
> >>
> >> Why the extra do{}while? [elsewhere too]
> >
> >Not sure, may be to get a scope to define 'mnt' here. Jan ?
>
> What I was implicitly suggesting that mnt could be moved into the
> normal 'function scope'.
>
>
> Jan
This code can't stay anyway so it's kind of moot. find_mnt() is bogus,
and the topmost and overlaid mappings need to be changed from
dentry->dentry to (vfsmnt,dentry)->(vfsmnt,dentry) in order to cope with
bind mounts and mount namespaces.
-serge
next prev parent reply other threads:[~2007-05-16 20:06 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-14 9:37 [RFC][PATCH 0/14] VFS based Union Mount(v1) Bharata B Rao
2007-05-14 9:38 ` [RFC][PATCH 1/14] Add union mount documentation Bharata B Rao
2007-05-14 9:39 ` [RFC][PATCH 2/14] Add a new mount flag (MNT_UNION) for union mount Bharata B Rao
2007-05-14 20:38 ` Jan Engelhardt
2007-05-15 8:16 ` Bharata B Rao
2007-05-15 12:06 ` Eric Van Hensbergen
2007-05-15 12:53 ` Jan Blunck
2007-05-14 9:39 ` [RFC][PATCH 3/14] Add the whiteout file type Bharata B Rao
2007-05-14 20:39 ` Jan Engelhardt
2007-05-15 6:00 ` Jan Blunck
2007-05-14 9:40 ` [RFC][PATCH 4/14] Add config options for union mount Bharata B Rao
2007-05-14 9:40 ` [RFC][PATCH 5/14] Introduce union stack Bharata B Rao
2007-05-14 20:23 ` Badari Pulavarty
2007-05-14 20:51 ` Jan Engelhardt
2007-05-19 10:18 ` Paul Dickson
2007-05-22 16:35 ` Jan Engelhardt
2007-05-23 13:25 ` Serge E. Hallyn
2007-05-14 20:48 ` Jan Engelhardt
2007-05-15 7:19 ` Jan Blunck
2007-05-14 22:40 ` Badari Pulavarty
2007-05-15 6:28 ` Bharata B Rao
2007-05-14 9:41 ` [RFC][PATCH 6/14] Union-mount dentry reference counting Bharata B Rao
2007-05-14 20:57 ` Jan Engelhardt
2007-05-14 9:41 ` [RFC][PATCH 7/14] Union-mount mounting Bharata B Rao
2007-05-15 7:29 ` Jan Engelhardt
2007-05-16 5:04 ` Bharata B Rao
2007-05-14 9:42 ` [RFC][PATCH 8/14] Union-mount lookup Bharata B Rao
2007-05-15 7:57 ` Jan Engelhardt
2007-05-16 5:08 ` Bharata B Rao
2007-05-16 19:28 ` Jan Engelhardt
2007-05-16 20:06 ` Serge E. Hallyn [this message]
2007-05-15 14:00 ` Trond Myklebust
2007-05-18 11:05 ` Bharata B Rao
2007-05-14 9:42 ` [RFC][PATCH 9/14] Union-mount readdir Bharata B Rao
2007-05-14 10:43 ` Carsten Otte
2007-05-14 11:15 ` Bharata B Rao
2007-05-14 9:43 ` [RFC][PATCH 10/14] In-kernel file copy between union mounted filesystems Bharata B Rao
2007-05-16 7:57 ` Jan Engelhardt
2007-05-18 11:10 ` Bharata B Rao
2007-05-18 13:47 ` Shaya Potter
2007-05-22 3:13 ` Bharata B Rao
2007-05-22 6:25 ` Jan Engelhardt
2007-05-22 8:38 ` Bharata B Rao
2007-05-22 12:35 ` Shaya Potter
2007-05-23 10:41 ` Bharata B Rao
2007-05-14 9:43 ` [RFC][PATCH 11/14] VFS whiteout handling Bharata B Rao
2007-05-16 8:06 ` Jan Engelhardt
2007-05-14 9:44 ` [RFC][PATCH 12/14] ext2 whiteout support Bharata B Rao
2007-05-16 8:07 ` Jan Engelhardt
2007-05-14 9:44 ` [RFC][PATCH 13/14] ext3 " Bharata B Rao
2007-05-14 20:16 ` Badari Pulavarty
2007-05-15 6:26 ` Bharata B Rao
2007-05-15 8:31 ` Jan Blunck
2007-05-14 20:17 ` Andreas Dilger
2007-05-14 20:35 ` Jan Blunck
2007-05-15 14:28 ` Theodore Tso
2007-05-14 9:45 ` [RFC][PATCH 14/14] tmpfs " Bharata B Rao
2007-05-14 16:13 ` Hugh Dickins
2007-05-14 19:20 ` Jan Blunck
2007-05-14 19:35 ` Hugh Dickins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070516200647.GA8961@sergelap.austin.ibm.com \
--to=serue@us.ibm.com \
--cc=bharata@linux.vnet.ibm.com \
--cc=j.blunck@tu-harburg.de \
--cc=jengelh@linux01.gwdg.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).